Victor Adossi (Jan 09 2025 at 07:49): Victor Adossi (Jan 09 2025 at 07:49):Hey all, to better separate the operational code of StarlingMonkey from the other things (scripts, cmake, Rust crates, etc) any objections to moving the C++ source code to src/ rather than having modules mixed into the top level directory?
It's a little thing but I think it would help repo organization a bunch.
Tomasz Andrzejak (Jan 09 2025 at 15:51):That sounds like a good idea to me.
Tomasz Andrzejak (Jan 09 2025 at 15:57):Is this urgent or can this wait for pending PRs to be merged? I have 3 PRs ready to go (File API, createObjectURL and FormData).
Victor Adossi (Jan 09 2025 at 15:59):This can absolutely wait! I'll push up the PR I wrote as draft for now, and refactor as those others land!
Definitely don't want to hold up that progress :)
Victor Adossi (Jan 09 2025 at 15:59):https://github.com/bytecodealliance/StarlingMonkey/pull/194
Victor Adossi (Jan 09 2025 at 16:00):Would appreciate feedback on the cmake changes in the meantime, from anyone with spare cycles!
Victor Adossi (Jan 09 2025 at 20:16):Welp, that was an incredibly painful exploration of cmake. But now that refactor PR CI is finally :green:
Going to leave it in draft till some later date, either after the other stuff merges or next JS meeting
Victor Adossi (Jan 22 2025 at 17:38):Ah forgot to bring this up in the meeting, but now that the other stuff has merged ahead of this, do we still want this PR to happen? If we're happy with the codebase organization as it is then I'll just close it out!
@Till Schneidereit are you feeling like it's not going to be worth the time to review (assuming a rebase)?
Till Schneidereit (Jan 22 2025 at 17:41):ah, right—I had also meant to talk about this, but forgot. I think the codebase could certainly use some amount of reorganization, but I'm personally not entirely convinced that the PR you opened is a sufficient improvement to justify the effort required. In particular given that at some—hopefully not too distant—point we'll want to make things more Rust focused, and will want to reorganize things in yet another way then
Victor Adossi (Jan 22 2025 at 17:43):Ah reasonable -- yes the Rust experimentation PR still hasn't landed, which will cause some changes, but hopefully only to the crates folder at the root
Victor Adossi (Jan 22 2025 at 17:44):That said, I'm happy to close out the PR for now -- if it's not a pressing problem we've got other fish to fry
Till Schneidereit (Jan 22 2025 at 17:46):oh, the Rust PR that's currently open won't change other things, agreed. But eventually I very much would like to move StarlingMonkey from being a C++ runtime with support for Rust to being a Rust runtime with support for C++ builtins. And that should come with more a substantial reorganization
Victor Adossi (Jan 22 2025 at 17:54):from being a C++ runtime with support for Rust to being a Rust runtime with support for C++ builtins
Definitely looking forward to that!
Last updated: Jan 24 2025 at 00:11 UTC