Stream: jco

Topic: ✔ conformance test suite


view this post on Zulip Yoshua Wuyts (Oct 24 2023 at 01:42):

I've put up the PR finalizing the conformance test suite: https://github.com/bytecodealliance/jco/pull/226

Closes #178. This finishes generating conformance tests from Wasmtime's conformance test suite. The main logic of this PR lives in xtask/generate/tests.rs and crates/test-utils/src/lib.rs files. Th...

view this post on Zulip Yoshua Wuyts (Oct 24 2023 at 01:42):

I was surprised at how fast it executes, since we're shelling out like a lot for this one

view this post on Zulip Yoshua Wuyts (Oct 24 2023 at 01:42):

But I think if we land it, it should make it a lot easier to start writing tests since we can then start piggy backing off wasmtime's tests

view this post on Zulip Guy Bedford (Oct 24 2023 at 01:49):

nice! thanks for figuring this one out

view this post on Zulip Notification Bot (Oct 24 2023 at 23:36):

Yoshua Wuyts has marked this topic as resolved.

view this post on Zulip Yoshua Wuyts (Nov 14 2023 at 21:52):

I've updated all issues with their respective conformance tests - to help us track how we're doing on that front. Apologies for not adding that information sooner.

view this post on Zulip Yoshua Wuyts (Nov 14 2023 at 21:52):

From chatting with @Guy Bedford, getting tests to pass for already-merged APIs is parallelizable work. So if anyone is unsure how they can help; that's a great way to contribute.

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:03):

Okay, all conformance tests have been updated in the tracking issues with their current status

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:07):

@Alex Crichton hey quick question about wasmtime's test programs - are all of them expected to pass, or are some of them stubbed out?

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:10):

hmmmmmmmmm, noooo - nevermind - I think they should all pass

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:10):

sorry about the ping

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:11):

(For context: I was trying to get api-time to pass - but it's giving me an unreachable!. I figured that might be because preview 1 doesn't implement Duration or SystemTime - but it seems like it does)

view this post on Zulip Yoshua Wuyts (Nov 16 2023 at 00:11):

so something else is giving me the unreachable, heh.


Last updated: Dec 23 2024 at 13:07 UTC