I have a draft PR up reworking the ad-hoc config file introduced by wasm-pkg-loader
into a new wasm-pkg-common
crate (along with some common packaging-related types).
tldr:
# Override default registry
default_registry = "bytecodealliance.org" # this is the hard-coded default
[package_registries]
# Namespace prefix mapping is made more explicit with wildcard syntax
"wasi:*" = "wasi.dev"
# Allow mapping individual packages too
"example:foo" = "example.com"
[registry."bytecodealliance.org"]
# Optional backend type will override automatic detection (`.well-known/wasm-pkg/registry.json`)
type = "warg"
# Backend-specific config is opaque to the wasm-pkg-common crate; individual "sources" will parse these
[registry."wasi.dev".oci]
url = "https://private-registry.example.com"
auth = { username = "open", password = "sesame" }
# Alternative syntax with inline backend config table
[registry."wa.dev"]
# type = "warg" <- implicit due to well-known config
warg = { auth_token = "top_secret" }
I don't think allowing or encouraging inline passwords/secrets is a good idea
Eh yeah that isn't really part of the change just the first thing I came up with for the example
Backend-specific config is opaque to the wasm-pkg-common crate; individual "sources" will parse these
I haven't actually integrated this part yet, which would produce more realistic examples
Mostly interested in initial feedback on the top-level structure: [package_registries]
and [registries.<name>.<backend>]
. We'll probably be stuck with at least backward-compat code for whatever we land on for a while.
Ya, I'm still thinking about the [package_registries]
bit.
I think it's good to offer people the tools to have local registry mappings, but the more we encourage people to do so, the more likely it is that when they go to push something its dependencies aren't compatible with the registry it's being published to in a way that breaks resolving
I agree that it doesn't make a lot of sense at the global level, but I think its probably a requirement at the workspace level.
Implicit here is the idea that this config file format would also apply to workspaces (e.g. ./.wasm-pkg/config.toml
)
Sure, the risk of making packages that aren't valid in your home registry is still present though.
I'm not sure about the granularity here, does it make sense to make all mappings package-level and offer wildcards? I'd be tempted to let people only configure whole namespaces initially.
In that same vein, what do you think about making this initial version rather minimal and expand as we have use cases / requests for things?
Also, as an aside: I'd be interested in a workspace-level config that says "don't use any defaults from anywhere else everything must be specified here" that projects interested in high amounts of reproducibility can turn on.
Admittedly the feature is currently driven by the very simple need to be able to override the registry for the root component, but I do think that the ability to patch single dependencies is too useful to ignore.
If you patch in an incompatible component then composition will (hopefully/usually) fail, right?
I guess an open question is whether a single overridden component's own dependencies would then be taken from that registry? :thinking:
actually that question applies equally to namespace overrides
Updated PR based on feedback:
# Override default registry
default_registry = "bytecodealliance.org" # this is the hard-coded default
[namespace_registries]
wasi = "wasi.dev"
[package_registry_overrides]
"example:foo" = "example.com"
[registry."bytecodealliance.org"]
# Optional backend type will override automatic detection (`.well-known/wasm-pkg/registry.json`)
type = "warg"
warg = { url = "https://warg.example.com" }
# Backend-specific config is opaque to the wasm-pkg-common crate; individual "sources" will parse these
[registry."wasi.dev".oci]
registry = "private-registry.example.com"
Last updated: Nov 22 2024 at 17:03 UTC