Lann Martin (Aug 28 2023 at 17:03): Lann Martin (Aug 28 2023 at 17:03):Any concerns with changing e.g. PackageGrantFlat.permission to repeated permissions?
Lann Martin (Aug 28 2023 at 17:04):This is actually a backward-compatible change under protobuf's binary encoding
Robin Brown (Aug 28 2023 at 17:58):The design philosophy for entries is that they are individually simple and you can compose them together to do more complex things by batching them in a record. It's nice for the state machine if they don't try and do too many things.
Lann Martin (Aug 28 2023 at 18:01):I guess we can losslessly compress records if size becomes an issue
Robin Brown (Aug 28 2023 at 18:23):I think this kind of change is fine as long as we keep it to 1 key and N permissions.
Lann Martin (Aug 28 2023 at 19:02):https://github.com/bytecodealliance/registry/pull/188
Lann Martin (Aug 28 2023 at 19:16):Turns out this isn't entirely backward-compatible under proto3 encoding after all, but given that the tooling doesn't really support grant/revoke yet I think its a reasonably safe change to make
Robin Brown (Aug 28 2023 at 19:30):I don't think we need backwards compatible yet
Lann Martin (Aug 28 2023 at 19:31):Yeah just trying not to break logs again before next week
Robin Brown (Aug 28 2023 at 19:32):I think our plan should be to finalize any breaking changes by Wednesday.
Last updated: Dec 23 2024 at 12:05 UTC