Peter Huene (Apr 18 2023 at 18:21): Peter Huene (Apr 18 2023 at 18:21):Just a heads up that I expect to put up a large PR today for warg-server that can conditionally compile-in support for persisting registry data to a PostgresQL instance (you can still use the in-memory store from environments that don't care to persist the registry, e.g. client integration tests, via a CLI option). With this feature, the registry state survives restarts. It won't be everything we need, but it's a step towards getting the server from prototype to a reference implementation.
It'll also be lacking in tests (general problem with the implementation currently). My goal for the remainder of this week is to focus on adding test coverage for both client and server.
Victor Adossi (Apr 19 2023 at 02:15):hey @Peter Huene that sounds awesome -- any sneak peek how the --content-dir option will change? I'm imagining something like --content-store postgresql://localhost:5432/warg (and makes sense to probably take that via ENV as well), but excited to see what you came up with
Peter Huene (Apr 19 2023 at 03:01):Right now the content store isn't changing as part of this PR, but I'm imaging something with similar pluggable backbends for putting the package contents into a blob store, for example, in addition to the existing file system implementation
Peter Huene (Apr 19 2023 at 03:04):This PR is just for the registry data itself, and you use it like --store postgres with the URL passed via environment (happy to do it another way too)
Peter Huene (Apr 19 2023 at 03:05):Probably should be named --data-store as the option
Victor Adossi (Apr 19 2023 at 03:08):Ah thanks for the explanation -- I missed that the content store would be unchanged -- I like the ENV pass, I guess the only thing I'd add is that it would be nice to specify the store itself via ENV as well (enabling a no-CLI-arg usage), but not sure if you already have that.
Also :+1: on the rename, though I'll patiently await the PR to read it and learn
Robin Brown (Apr 24 2023 at 17:51):FYI, while we'll be able to make many things plug-able using the CLI, there are some things e.g. custom policy that you'll need to extend/configure programmatically by using the server crate as a library.
Lann Martin (Apr 24 2023 at 17:51):Not with wasm? :smile:
Robin Brown (Apr 24 2023 at 17:53):Someday... aren't you in the "don't boil the ocean" camp though? :laughing:
Lann Martin (Apr 24 2023 at 17:54):Yeah but I would put custom policies in that ocean
Robin Brown (Apr 24 2023 at 17:57):Fair, though that takes us from "registry reference implementation" to "registry framework" territory which will take a while to flesh out.
Last updated: Oct 23 2024 at 20:03 UTC