Stream: wit-bindgen

Topic: ✔ requiring semicolons


view this post on Zulip Scott Waye (Oct 19 2023 at 14:15):

Has wit-bindgen had wit-parser bumped to require ;s ? I think I saw some discussion about semi colons

view this post on Zulip Scott Waye (Oct 19 2023 at 14:17):

If so I guess I need to update the wasmtime-wasi wit to resolve this

 error: failed to parse package: C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wasmtime-wasi-13.0.0\wit

       Caused by:
           expected ';', found keyword `import`
                --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wasmtime-wasi-13.0.0\wit\command-extended.wit:5:3
                 |
               5 |   import wasi:clocks/monotonic-clock
                 |   ^

view this post on Zulip Lann Martin (Oct 19 2023 at 14:35):

I think that is a bug, at least going by @Alex Crichton's announced timeline (see also wasm-tools#1205)

Low level tooling for WebAssembly in Rust. Contribute to bytecodealliance/wasm-tools development by creating an account on GitHub.

view this post on Zulip Alex Crichton (Oct 19 2023 at 15:36):

@Scott Waye semicolons should not be required yet, but you may be running in an environment that sets the env var to require semicolons. If you're not doing that then there may be a bug, and/or you can set WIT_REQUIRE_SEMICOLONS=0 in the environment. If none of that works let me know and I should dig in

view this post on Zulip Notification Bot (Oct 19 2023 at 15:37):

4 messages were moved here from #wit-bindgen > broken deps by Alex Crichton.

view this post on Zulip Scott Waye (Oct 19 2023 at 16:04):

Thanks, yes it is in the env, for my PR here: https://github.com/bytecodealliance/wit-bindgen/blob/main/.github/workflows/main.yml#L35

view this post on Zulip Alex Crichton (Oct 19 2023 at 16:04):

Ah ok cool makes sense, and yeah I'm trying to opt-in on a per-repo basis for the time being to make sure everything is prepared for when semicolons are required

view this post on Zulip Scott Waye (Oct 19 2023 at 16:04):

I'll revert it in my branch to see how it goes

view this post on Zulip Alex Crichton (Oct 19 2023 at 16:05):

Aha that's actually a really good point that if you use wasmtime as a dep it's difficult

view this post on Zulip Alex Crichton (Oct 19 2023 at 16:05):

I'm gonna go confirm the wasmtime 14 release has semicolons now

view this post on Zulip Notification Bot (Oct 20 2023 at 16:53):

Scott Waye has marked this topic as resolved.


Last updated: Dec 23 2024 at 12:05 UTC