Stream: wamr

Topic: Unit tests for wasm-c-api?

view this post on Zulip Michael Martin (Oct 06 2021 at 22:58):

Hi, I have a small bugfix in wamr's implementation of the C API I'd like to contribute. Are there any publically available unit tests for this? The spec tests under wamr-test-suites don't seem to cover the API code, and I'd like to include a unit/regression test with the patch.

view this post on Zulip Wenyong Huang (Oct 08 2021 at 01:51):

Hi, you can test the wasm-c-api samples under <wamr_root>/samples/wasm-c-api, also these samples will be tested by the github CI when the PR is created.

view this post on Zulip Wang Xin (Oct 08 2021 at 02:02):

Michael Martin said:

Hi, I have a small bugfix in wamr's implementation of the C API I'd like to contribute. Are there any publically available unit tests for this? The spec tests under wamr-test-suites don't seem to cover the API code, and I'd like to include a unit/regression test with the patch.

It is great to provide unit/regression test in the patch.

view this post on Zulip Michael Martin (Oct 11 2021 at 23:32):

Great, I'll look into that.

view this post on Zulip Michael Martin (Oct 12 2021 at 04:28):

https://github.com/bytecodealliance/wasm-micro-runtime/pull/782 sent for review.

Allow an empty imports array when creating a new instance. by mykmartin · Pull Request #782 · bytecodealliance/wasm-micro-runtime
This makes the API code more robust (I hit the problem because I passed in an empty imports vector rather than NULL), especially in use cases where imports might be constructed dynamically. I'v...

Last updated: Nov 22 2024 at 16:03 UTC