RFC notifications bot (Mar 12 2021 at 00:57): RFC notifications bot (Mar 12 2021 at 00:57):cfallin opened PR #10 from cranelift-backend-transition to main:
This RFC proposes to switch the default Cranelift compiler backend for the
cranelift-codegencrate (i.e., use of Cranelift as a library) and for Wasmtime from the old x86-64 backend to the new x86-64 backend. Details on how we should decide, what steps we should take to build confidence, ensure backwards compatibility, and gradually switch over are proposed.
RFC notifications bot (Mar 12 2021 at 09:39):bjorn3 submitted PR Review.
RFC notifications bot (Mar 12 2021 at 09:39):bjorn3 created PR Review Comment:
#1140](bjorn3/rustc_codegen_cranelift#1140)) have already switched to using the new backend by default (Lucet) or as only (cg\_clif) option.
RFC notifications bot (Mar 12 2021 at 09:39):bjorn3 submitted PR Review.
RFC notifications bot (Mar 12 2021 at 09:39):bjorn3 created PR Review Comment:
incompleteness because it is not a regression overall.
RFC notifications bot (Mar 12 2021 at 09:41):bjorn3 submitted PR Review.
RFC notifications bot (Mar 12 2021 at 09:41):bjorn3 created PR Review Comment:
Maybe saltwater by @jyn514? It has been a couple of months since the last change through it seems.
RFC notifications bot (Mar 12 2021 at 09:43):bjorn3 submitted PR Review.
RFC notifications bot (Mar 12 2021 at 11:37):jyn514 submitted PR Review.
RFC notifications bot (Mar 12 2021 at 11:37):jyn514 created PR Review Comment:
I don't really work much on it any more, it uses like a 6 month old version on cranelift. I wouldn't make decisions based on it.
RFC notifications bot (Mar 12 2021 at 11:37):jyn514 edited PR Review Comment.
RFC notifications bot (Mar 12 2021 at 22:37):joshtriplett submitted PR Review.
RFC notifications bot (Mar 12 2021 at 22:37):joshtriplett created PR Review Comment:
This transition's rationale largely derives from the rationale for the
RFC notifications bot (Mar 15 2021 at 04:40):cfallin updated PR #10 from cranelift-backend-transition to main.
RFC notifications bot (Mar 15 2021 at 04:40):cfallin submitted PR Review.
RFC notifications bot (Mar 15 2021 at 04:40):cfallin created PR Review Comment:
Thanks!
RFC notifications bot (Mar 15 2021 at 04:40):cfallin submitted PR Review.
RFC notifications bot (Mar 15 2021 at 04:40):cfallin created PR Review Comment:
Thanks!
RFC notifications bot (Mar 15 2021 at 04:40):cfallin submitted PR Review.
RFC notifications bot (Mar 15 2021 at 04:40):cfallin created PR Review Comment:
Fixed, thanks!
RFC notifications bot (Mar 15 2021 at 15:57):bnjbvr submitted PR Review.
RFC notifications bot (Mar 15 2021 at 15:57):bnjbvr submitted PR Review.
RFC notifications bot (Mar 15 2021 at 15:57):bnjbvr created PR Review Comment:
In order to help guiding the answer to this question, how about another question: from the performance analysis that we've made on the new backend, it would be interesting to get a rough idea of the speedups we can reach, and with which associated cost? What I mean is, if we think we can get e.g. a 10% speedup easily (famous last words, but imagine in e.g. one or two months of work), then it makes it easier to accept a degradation in the short-term.
RFC notifications bot (Mar 25 2021 at 19:42):jedisct1 submitted PR Review.
RFC notifications bot (Mar 25 2021 at 21:07):pchickey submitted PR Review.
RFC notifications bot (Mar 26 2021 at 01:42):abrown submitted PR Review.
RFC notifications bot (Mar 26 2021 at 02:08):jlb6740 submitted PR Review.
RFC notifications bot (Mar 26 2021 at 08:20):bnjbvr submitted PR Review.
RFC notifications bot (Mar 26 2021 at 16:16):cfallin merged PR #10.
RFC notifications bot (Mar 26 2021 at 16:19):cfallin edited PR #10 from cranelift-backend-transition to main:
This RFC proposes to switch the default Cranelift compiler backend for the
cranelift-codegencrate (i.e., use of Cranelift as a library) and for Wasmtime from the old x86-64 backend to the new x86-64 backend. Details on how we should decide, what steps we should take to build confidence, ensure backwards compatibility, and gradually switch over are proposed.
Last updated: Dec 23 2024 at 12:05 UTC