alexcrichton commented on Issue #5:
I think that's actually a good point that having an
enum
here is probably the way to go. We can always extend the enum in a backwards-compatible way (or just add more methods toConfig
) and I think it's a good observation that the allocation strategy is so tightly coupled to the internals of wasmtime we wouldn't really expect anyone to implement the traits anyway.The
wasmtime
crate changes look good here to me! I'm not reading the internal changes too too closely, but I'm assuming they're all fine as well (and are easy to change if a problem arises)
peterhuene commented on Issue #5:
I agree that
Default
doesn't really describe what's going on. I'll go withOnDemand
with a comment calling it the default allocation strategy.
peterhuene commented on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [ ] @alexcrichton
- [ ] @pchickey
- [ ] @fitzgen
- [ ] @sunfishcode
- [ ] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [ ] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
fitzgen edited a comment on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [ ] @alexcrichton
- [ ] @pchickey
- [x] @fitzgen
- [ ] @sunfishcode
- [ ] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [ ] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
alexcrichton edited a comment on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [x] @alexcrichton
- [ ] @pchickey
- [x] @fitzgen
- [ ] @sunfishcode
- [ ] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [ ] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
alexcrichton edited a comment on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [x] @alexcrichton
- [ ] @pchickey
- [x] @fitzgen
- [ ] @sunfishcode
- [x] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [ ] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
peterhuene edited a comment on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [x] @alexcrichton
- [ ] @pchickey
- [x] @fitzgen
- [ ] @sunfishcode
- [x] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [x] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
peterhuene edited a comment on Issue #5:
Motion to finalize with a disposition to merge
I'm proposing that we merge this RFC.
Early feedback has been received and all requested outstanding changes to the proposal has been made.
An implementation in Wasmtime has already been started.
Stakeholders sign-off
Tagging all employees of BA-affiliated companies who have committed to the Wasmtime repo in the last three months plus anyone who has given feedback on this PR as a stakeholder.
Fastly
- [x] @alexcrichton
- [x] @pchickey
- [x] @fitzgen
- [ ] @sunfishcode
- [x] @cfallin
- [ ] @iximeow
- [ ] @fst-crenshaw
IBM
- [ ] @uweigand
Intel
- [x] @abrown
Mozilla
- [ ] @julian-seward1
- [ ] @yurydelendik
peterhuene commented on Issue #5:
Entering Final Call Period
Once any stakeholder from a different group has signed off, the RFC will move into a 10 calendar day final comment period (FCP), long enough to ensure that other stakeholders have at least a full business week to respond.
The FCP will end on February 26th.
peterhuene commented on Issue #5:
The FCP has elapsed without any objections being raised; as a result I'm going to merge this. Thanks everyone!
Last updated: Dec 23 2024 at 13:07 UTC