Stream: git-wasmtime

Topic: wasmtime / issue #9856 impl Debug and/or Default for Spar...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 18 2024 at 21:11):

wtachau opened issue #9856:

Hello, is there a reason that SparseMap doesn't impl std::fmt::Debug and/or Default? I would like to use it inside my own data structures that derive those impls.

(I read these contribution guidelines which encouraged me to open an issue, please let me know if there's a more appropriate place to ask, thanks!)

view this post on Zulip Wasmtime GitHub notifications bot (Dec 18 2024 at 21:21):

cfallin commented on issue #9856:

This seems like a reasonable contribution to make -- I'd be happy to review a PR if you'd like to do this! The only thing I'd note right away is that we don't want to constrain K: Debug and V: Debug unconditionally -- let's have a trait impl that provides Debug if they both have that impl.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 18 2024 at 21:59):

wtachau commented on issue #9856:

thanks @cfallin! opened a PR here.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 18 2024 at 22:56):

cfallin closed issue #9856:

Hello, is there a reason that SparseMap doesn't impl std::fmt::Debug and/or Default? I would like to use it inside my own data structures that derive those impls.

(I read these contribution guidelines which encouraged me to open an issue, please let me know if there's a more appropriate place to ask, thanks!)


Last updated: Dec 23 2024 at 12:05 UTC