Stream: git-wasmtime

Topic: wasmtime / issue #9695 implement initial-cwd for wasi:cli...

Wasmtime GitHub notifications bot (Nov 29 2024 at 23:53):

ctaggart opened issue #9695:

For https://github.com/WebAssembly/wasi-cli/blob/main/wit/environment.wit, the initial-cwd implementation currently just returns None. Adding this issue highlighted by the FIXME:

https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasi/src/host/env.rs#L14-L17

Wasmtime GitHub notifications bot (Dec 02 2024 at 23:04):

alexcrichton commented on issue #9695:

This'd perhaps be a good first issue for someone to get their feet wet if they're interested. The general idea to implement this would probably be something like:

• Add a builder method to WasiCtxBuilder.
• Fill in initial_cwd linked above to read the WasCtx "built value"
• This'll still be None by default for backwards-compat
• The wasmtime CLI can probably grow a few new options:
  • -S cwd=<path> - explicitly setting the path to the cwd
  • (if you're adventurous) -S inherit-fs - inherit the whole filesystem and set the cwd to the process's cwd
  • (if you're extra adventurous) unify -S inherit-* under -S inherit[=fs,network,...] where -S inherit can be "inherit the whole shebang" while -S inherit-fs could be -S inherit=fs.

Wasmtime GitHub notifications bot (Dec 02 2024 at 23:05):

alexcrichton added the good first issue label to Issue #9695.

Wasmtime GitHub notifications bot (Dec 13 2024 at 10:58):

stephenmuss commented on issue #9695:

@alexcrichton I'd be keen to have a crack at this.

I have a wip branch and commit at https://github.com/stephenmuss/wasmtime/commit/af44736104b2803b451faa0e783461ab88515c29, would be good to know I'm heading down the right path.

Wasmtime GitHub notifications bot (Dec 13 2024 at 16:59):

alexcrichton commented on issue #9695:

Looking good! That's mostly just missing a test and should be good to land :+1:

Last updated: Dec 23 2024 at 12:05 UTC