Stream: git-wasmtime

Topic: wasmtime / issue #9694 Documentation: Wrong doc about Con...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2024 at 03:51):

ifsheldon opened issue #9694:

https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/src/config.rs#L998

Here, the documented default is wrong, because the default features of wasmtime include component-model
https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/Cargo.toml#L137

and the enabled features is determined at compile time by
https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/src/config.rs#L1999

The documentation should be something like 

This is `cfg!(feature = "component-model")` by default.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2024 at 19:33):

alexcrichton closed issue #9694:

https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/src/config.rs#L998

Here, the documented default is wrong, because the default features of wasmtime include component-model
https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/Cargo.toml#L137

and the enabled features is determined at compile time by
https://github.com/bytecodealliance/wasmtime/blob/66910067642ce2ddf5509845306508f89a24fc9e/crates/wasmtime/src/config.rs#L1999

The documentation should be something like 

This is `cfg!(feature = "component-model")` by default.

Last updated: Dec 23 2024 at 12:05 UTC