Stream: git-wasmtime

Topic: wasmtime / issue #9667 wasmtime-wasi: Unexpected tcp stre...

Wasmtime GitHub notifications bot (Nov 28 2024 at 09:05):

Heap-Hop edited issue #9667:

https://github.com/bytecodealliance/wasmtime/blob/67674881db5fbdbba8594feb52655aaa351a5f77/crates/wasi/src/tcp.rs#L719-L723

Returning 0 for std::io::ErrorKind::WouldBlock causes downstream to interpret it as a closed stream, see:
https://github.com/yoshuawuyts/wstd/issues/25#issuecomment-2493294087.
https://github.com/yoshuawuyts/wstd/blob/5ce367add5e7bcb569b6487453cb9ba94468dc99/src/io/copy.rs#L12

This is also found in:
https://github.com/bytecodealliance/wasmtime/blob/67674881db5fbdbba8594feb52655aaa351a5f77/crates/test-programs/src/bin/preview2_tcp_streams.rs#L17-L22

Given that the wit files already include many would-block errors, would it make sense to extend stream-error to include a would-block?

Wasmtime GitHub notifications bot (Nov 28 2024 at 14:29):

Heap-Hop commented on issue #9667:

@pchickey https://github.com/bytecodealliance/wasmtime/actions/runs/12070585313/job/33660435175?pr=9691#step:18:419

Wasmtime GitHub notifications bot (Nov 28 2024 at 16:45):

pchickey commented on issue #9667:

Thanks! Its a holiday weekend here so I’ll get to this next week.

Last updated: Dec 23 2024 at 12:05 UTC