Stream: git-wasmtime

Topic: wasmtime / issue #9568 Refactor the `MemoryCreator` trait...

Wasmtime GitHub notifications bot (Nov 05 2024 at 23:53):

alexcrichton opened issue #9568:

In #NNNN the memory_may_move configuration knob was plumbed into memories themselves to limit the growth of the memory. This knob is not surfaced in the custom MemoryCreator trait, however, and memories created from that trait are pessimistically assumed to always possibly move in memory. This issue is intended to track refactoring this trait to improve this situation and enable plumbing the information a bit further.

Ideally the MemoryCreator and RuntimeMemoryCreator traits are merged. After looking at this for a bit this'll require some deeper refactoring to keep things making sense.

Wasmtime GitHub notifications bot (Nov 06 2024 at 00:29):

alexcrichton edited issue #9568:

In #9569 the memory_may_move configuration knob was plumbed into memories themselves to limit the growth of the memory. This knob is not surfaced in the custom MemoryCreator trait, however, and memories created from that trait are pessimistically assumed to always possibly move in memory. This issue is intended to track refactoring this trait to improve this situation and enable plumbing the information a bit further.

Ideally the MemoryCreator and RuntimeMemoryCreator traits are merged. After looking at this for a bit this'll require some deeper refactoring to keep things making sense.

Wasmtime GitHub notifications bot (Nov 07 2024 at 19:18):

alexcrichton closed issue #9568:

In #9569 the memory_may_move configuration knob was plumbed into memories themselves to limit the growth of the memory. This knob is not surfaced in the custom MemoryCreator trait, however, and memories created from that trait are pessimistically assumed to always possibly move in memory. This issue is intended to track refactoring this trait to improve this situation and enable plumbing the information a bit further.

Ideally the MemoryCreator and RuntimeMemoryCreator traits are merged. After looking at this for a bit this'll require some deeper refactoring to keep things making sense.

Last updated: Dec 23 2024 at 12:05 UTC