Stream: git-wasmtime

Topic: wasmtime / issue #9419 Using wkg to manage wit dependencies

Wasmtime GitHub notifications bot (Oct 09 2024 at 16:34):

thomastaylor312 opened issue #9419:

Now that we have wkg (from wasm-pkg-tools) available and working for pulling wit dependencies, would people be amenable to using wkg to fetch dependencies in the wasi-* crates in this repo? The main idea here is to start using the packaging tooling in all the places where it makes sense and it would avoid needing to copy/paste interfaces around

The main changes this would entail are

• We would commit a wkg.lock file in each of the wasi crates
• Updates to contributing/developer docs to indicate that wkg should be used for updating the dependencies
• (Optional) We would no longer commit the deps directory and instead fetch at build time. This would require an update to the build pipelines. This isn't a requirement but would make things cleaner

I'm totally fine if people don't want to use this, but wanted to at least bring it up for discussion! If we do want to do this, I can do the work to enable it

Wasmtime GitHub notifications bot (Oct 09 2024 at 20:06):

alexcrichton commented on issue #9419:

I think it'd be reasonable to do this! I think the best way to start would be to replace ci/vendor-wit.shwith wkg, so we'd still check in everything to the repo, but CI would run wkg instead of a "random bash script" to ensure that everything is vendored correctly (or the "random bash script" would be much simpler and just run wkg in a view invocations)

Wasmtime GitHub notifications bot (Oct 17 2024 at 16:38):

thomastaylor312 commented on issue #9419:

Awesome! I'll probably be doing this next week at some point. Working on integrating wkg into some other things right now and then I'll come over here to do it

Last updated: Nov 22 2024 at 16:03 UTC