thomastaylor312 opened issue #9419:
Now that we have
wkg
(from wasm-pkg-tools) available and working for pulling wit dependencies, would people be amenable to usingwkg
to fetch dependencies in thewasi-*
crates in this repo? The main idea here is to start using the packaging tooling in all the places where it makes sense and it would avoid needing to copy/paste interfaces aroundThe main changes this would entail are
- We would commit a
wkg.lock
file in each of the wasi crates- Updates to contributing/developer docs to indicate that
wkg
should be used for updating the dependencies- (Optional) We would no longer commit the deps directory and instead fetch at build time. This would require an update to the build pipelines. This isn't a requirement but would make things cleaner
I'm totally fine if people don't want to use this, but wanted to at least bring it up for discussion! If we do want to do this, I can do the work to enable it
alexcrichton commented on issue #9419:
I think it'd be reasonable to do this! I think the best way to start would be to replace
ci/vendor-wit.sh
withwkg
, so we'd still check in everything to the repo, but CI would runwkg
instead of a "random bash script" to ensure that everything is vendored correctly (or the "random bash script" would be much simpler and just runwkg
in a view invocations)
thomastaylor312 commented on issue #9419:
Awesome! I'll probably be doing this next week at some point. Working on integrating wkg into some other things right now and then I'll come over here to do it
Last updated: Dec 23 2024 at 12:05 UTC