Stream: git-wasmtime

Topic: wasmtime / issue #9311 `wasmtime::runtime::vm::const_expr...

Wasmtime GitHub notifications bot (Sep 25 2024 at 16:18):

fitzgen added the good first issue label to Issue #9311.

Wasmtime GitHub notifications bot (Sep 25 2024 at 16:18):

fitzgen added the wasmtime label to Issue #9311.

Wasmtime GitHub notifications bot (Sep 25 2024 at 16:18):

fitzgen opened issue #9311:

The instance field already provides access to that module via instance.env_module(). We should remove the module field, remove the module parameter from ContEvalContext::new, and replace old uses of self.module with self.instance.env_module().

Wasmtime GitHub notifications bot (Sep 25 2024 at 19:16):

Tirthnp commented on issue #9311:

Hey I would like to take an attempt at this. I am trying to learn about compiler and Rust. I have created this Draft PR: https://github.com/bytecodealliance/wasmtime/pull/9314, I am really sorry if I should ask for the issue to be assigned to me.

Wasmtime GitHub notifications bot (Sep 25 2024 at 19:35):

fitzgen commented on issue #9311:

Cool! Excited to take a look. Just a heads up that I am pretty busy with the Bytecode Alliance's plumbers summit through the rest of the week, so I probably won't take a look until next week. Someone else might beat me to it though.

Wasmtime GitHub notifications bot (Oct 03 2024 at 18:56):

evanmcc commented on issue #9311:

looks like this should be closed.

Wasmtime GitHub notifications bot (Oct 03 2024 at 20:58):

alexcrichton closed issue #9311:

The instance field already provides access to that module via instance.env_module(). We should remove the module field, remove the module parameter from ContEvalContext::new, and replace old uses of self.module with self.instance.env_module().

Wasmtime GitHub notifications bot (Oct 03 2024 at 20:58):

alexcrichton commented on issue #9311:

Thanks!

Last updated: Dec 23 2024 at 12:05 UTC