Stream: git-wasmtime

Topic: wasmtime / issue #9256 Expose remaining pooling allocator...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 16:41):

alexcrichton opened issue #9256:

Wasmtime's pooling instance allocator has a number of configuration options not all of which are reflected onto the CLI at this time around here. Ideally all of the pooling alloctator configuration options should be reflected on the CLI with a various -O pooling-... flag.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 16:41):

alexcrichton added the good first issue label to Issue #9256.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 16 2024 at 16:43):

alexcrichton commented on issue #9256:

I'm tagging this as a "good first issue" and the basic task would be:

  1. Write down a list of all configuration options on PoolingAllocationConfig
  2. Write down a list of configuration options that the wasmtime CLI supports configuring
  3. Figure out what's in list (1) and not in list (2)
  4. Add new options for these missing configuration flags along the lines of the items already in list (2)

We don't have exhaustive tests for Wasmtime's CLI options at this time so it's ok to skip the tests for this at this time and just rely on code review to catch issues.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2024 at 01:41):

vHugoObject commented on issue #9256:

Can I take this?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 19 2024 at 03:13):

alexcrichton commented on issue #9256:

Feel free!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 10 2024 at 19:34):

omarjatoi commented on issue #9256:

:face_palm: sorry @vHugoObject! I totally missed your comment before opening the PR.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 10 2024 at 19:49):

vHugoObject commented on issue #9256:

No problem at all, I have been too busy for this anyways.

On Thu, Oct 10, 2024 at 14:35 Omar Jatoi @.***> wrote:

:face_palm: sorry @vHugoObject <https://github.com/vHugoObject>! I totally missed
your comment before opening the PR.

—
Reply to this email directly, view it on GitHub
<https://github.com/bytecodealliance/wasmtime/issues/9256#issuecomment-2405890203>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEGOVS6TLKJ2OYTE6RRKMDZ23JHNAVCNFSM6AAAAABOJWBTWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVHA4TAMRQGM>
.
You are receiving this because you were mentioned.Message ID:
@.***>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 10 2024 at 19:53):

alexcrichton commented on issue #9256:

Landed in https://github.com/bytecodealliance/wasmtime/pull/9447, so I'm going to close this. Thkas @omarjatoi!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 10 2024 at 19:53):

alexcrichton closed issue #9256:

Wasmtime's pooling instance allocator has a number of configuration options not all of which are reflected onto the CLI at this time around here. Ideally all of the pooling alloctator configuration options should be reflected on the CLI with a various -O pooling-... flag.

Last updated: Oct 23 2024 at 20:03 UTC