Stream: git-wasmtime

Topic: wasmtime / issue #9229 Cranelift: Add feature enabling al...

Wasmtime GitHub notifications bot (Sep 11 2024 at 18:42):

bjorn3 opened issue #9229:

Feature

See title

Benefit

This makes it easier to enable support for all real architectures while avoiding the extra pulley-interpreter dependency that won't be necessary anyway due to not being an architecture for which object files can be compiled for.

Implementation

Add a cargo feature to the cranelift-codegen crate.

Alternatives

Explicitly spell out every real architecture in cg_clif and manually add new ones when they get added to cranelift-codegen.

Wasmtime GitHub notifications bot (Sep 11 2024 at 18:43):

bjorn3 edited issue #9229:

Feature

See title

Benefit

This makes it easier to enable support for all real architectures while avoiding the extra pulley-interpreter dependency that won't be necessary anyway due to not being an architecture for which object files can be compiled for.

Implementation

Add a cargo feature to the cranelift-codegen crate with all the features of all-arch except pulley. Or alternatively remove pulley from all-arch and require everyone who wants to use pulley to explicitly enable it.

Alternatives

Explicitly spell out every real architecture in cg_clif and manually add new ones when they get added to cranelift-codegen.

Wasmtime GitHub notifications bot (Sep 12 2024 at 22:37):

alexcrichton closed issue #9229:

Feature

See title

Benefit

This makes it easier to enable support for all real architectures while avoiding the extra pulley-interpreter dependency that won't be necessary anyway due to not being an architecture for which object files can be compiled for.

Implementation

Add a cargo feature to the cranelift-codegen crate with all the features of all-arch except pulley. Or alternatively remove pulley from all-arch and require everyone who wants to use pulley to explicitly enable it.

Alternatives

Explicitly spell out every real architecture in cg_clif and manually add new ones when they get added to cranelift-codegen.

Last updated: Dec 23 2024 at 12:05 UTC