Stream: git-wasmtime

Topic: wasmtime / issue #9081 large enums slow down compilation


view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2024 at 10:47):

MatthiasGrandl opened issue #9081:

Related to https://github.com/bytecodealliance/wit-bindgen/issues/1019

I have a large enum with 1424 cases. While it's completely broken on the client side, it works as expected on the host side, but compilation takes ages. On this Macbook Pro M3 Pro it takes 1 minute longer on a fresh compile than without the enum.

I attached the wit for testing.

icons.wit.txt

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 20:32):

alexcrichton commented on issue #9081:

I've tested that with #9122 the enum in question goes from generating 80_000 lines of code to 8_000 lines of code, which should be a large improvement. When that lands though can you confirm that it improves things locally as well? If the compile time is still too long I'll look into this further and see what else is generating a lot of code.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 20:39):

MatthiasGrandl commented on issue #9081:

@alexcrichton I would be happy to test it!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2024 at 21:24):

alexcrichton closed issue #9081:

Related to https://github.com/bytecodealliance/wit-bindgen/issues/1019

I have a large enum with 1424 cases. While it's completely broken on the client side, it works as expected on the host side, but compilation takes ages. On this Macbook Pro M3 Pro it takes 1 minute longer on a fresh compile than without the enum.

I attached the wit for testing.

icons.wit.txt

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 12:24):

MatthiasGrandl commented on issue #9081:

@alexcrichton tested the changes and they definitely solved my issue! thanks a lot!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2024 at 14:45):

alexcrichton commented on issue #9081:

Great, thanks for testing!


Last updated: Oct 23 2024 at 20:03 UTC