Stream: git-wasmtime

Topic: wasmtime / issue #8848 Winch: Assertion failure with satu...

Wasmtime GitHub notifications bot (Jun 20 2024 at 15:01):

alexcrichton added the winch label to Issue #8848.

Wasmtime GitHub notifications bot (Jun 20 2024 at 15:01):

alexcrichton added the fuzz-bug label to Issue #8848.

Wasmtime GitHub notifications bot (Jun 20 2024 at 15:01):

alexcrichton opened issue #8848:

Given this input:

(module
  (func (param f64 f64 f64 f64) (result f32 f64)
    f64.const 0
    local.get 0
    i64.const 0
    f64.const 0
    i64.const 0
    local.get 0
    f64.const 0
    i64.const 1
    i32.const 1
    i64.const 1
    f32.const 0
    local.get 0

    i32.const 0
    br_if 0

    drop
    drop
    drop
    drop
    drop
    drop
    i64.reinterpret_f64
    i64.const 0
    i64.xor
    drop
    drop
    drop
    drop
    drop
    drop
    f32.const 0
    f64.const 0
  )
)

since the implementation of saturating conversion instructions in #7909 this has panicked

$ cargo run --features winch --no-default-features --features compile compile -C compiler=winch ./testcase1.wasm -o /dev/null
...
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/wasmtime compile -C compiler=winch -o /dev/null ./foo.wat`
thread 'main' panicked at winch/codegen/src/codegen/context.rs:165:13:
assertion `left == right` failed
  left: 64
 right: 48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cc @saulecabrera

Wasmtime GitHub notifications bot (Jun 20 2024 at 15:02):

github-actions[bot] commented on issue #8848:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 21 2024 at 16:32):

saulecabrera commented on issue #8848:

Thanks for catching this one Alex. I'll take a look.

Wasmtime GitHub notifications bot (Jun 28 2024 at 16:58):

fitzgen closed issue #8848:

Given this input:

(module
  (func (param f64 f64 f64 f64) (result f32 f64)
    f64.const 0
    local.get 0
    i64.const 0
    f64.const 0
    i64.const 0
    local.get 0
    f64.const 0
    i64.const 1
    i32.const 1
    i64.const 1
    f32.const 0
    local.get 0

    i32.const 0
    br_if 0

    drop
    drop
    drop
    drop
    drop
    drop
    i64.reinterpret_f64
    i64.const 0
    i64.xor
    drop
    drop
    drop
    drop
    drop
    drop
    f32.const 0
    f64.const 0
  )
)

since the implementation of saturating conversion instructions in #7909 this has panicked

$ cargo run --features winch --no-default-features --features compile compile -C compiler=winch ./testcase1.wasm -o /dev/null
...
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/wasmtime compile -C compiler=winch -o /dev/null ./foo.wat`
thread 'main' panicked at winch/codegen/src/codegen/context.rs:165:13:
assertion `left == right` failed
  left: 64
 right: 48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cc @saulecabrera

Last updated: Nov 22 2024 at 17:03 UTC