Stream: git-wasmtime

Topic: wasmtime / issue #8832 wasi-http: Consider unhiding `add_...

Wasmtime GitHub notifications bot (Jun 18 2024 at 13:56):

lann opened issue #8832:

These functions allow linking just the types and outbound-handler interfaces without the rest of the proxy world. I'm not sure why they are currently hidden; this seems like a generally useful feature.

Wasmtime GitHub notifications bot (Jun 18 2024 at 13:58):

lann edited issue #8832:

These functions allow linking just the types and outbound-handler interfaces without the rest of the proxy world. I'm not sure why they are currently hidden; this seems like a generally useful feature.

They could probably use better names as well since they only add 2 out of 3 of the http interfaces.

Wasmtime GitHub notifications bot (Jun 18 2024 at 16:26):

landonxjames commented on issue #8832:

Just to give my use-case for this. I work on the AWS Rust SDK and I maintain our aws-smithy-wasm crate. This includes a WasiHttpClient for sending outbound HTTP calls to AWS services. So the full proxy world is overkill for my needs and I would prefer to link in the minimal set of interfaces that I need.

That seems possible today with the add_to_linker_get_host functions, but I haven't had time to go through and figure out what I actually need to implement for the host_getter yet.

Wasmtime GitHub notifications bot (Jun 18 2024 at 17:30):

lann commented on issue #8832:

As another use-case, Spin just uses the hidden function anyway :slightly_smiling_face: https://github.com/fermyon/spin/blob/bc86ff322cf3e1aee19e3001094a5231bcbcd9df/crates/trigger/src/lib.rs#L146

Wasmtime GitHub notifications bot (Jun 24 2024 at 15:39):

alexcrichton closed issue #8832:

These functions allow linking just the types and outbound-handler interfaces without the rest of the proxy world. I'm not sure why they are currently hidden; this seems like a generally useful feature.

They could probably use better names as well since they only add 2 out of 3 of the http interfaces.

Last updated: Nov 22 2024 at 16:03 UTC