Stream: git-wasmtime

Topic: wasmtime / issue #8714 Make wasmtime_wasi's `SocketAddrCh...

Wasmtime GitHub notifications bot (May 30 2024 at 19:54):

lann opened issue #8714:

Currently, the WasiCtxBuilder::socket_addr_check callback is synchronous. While this is often reasonable, I'm working on some code that wants to resolve inputs to this check asynchronously, which requires either delaying construction of the WasiCtx (which delays execution of the guest) or blocking the thread within the check.

Could this allow async callbacks? Either updating the existing signature (presumably breaking existing code, but with a trivial fix) or adding a new e.g. socket_addr_async_check method?

cc @rylev

Wasmtime GitHub notifications bot (May 30 2024 at 20:46):

lann commented on issue #8714:

From a brief out-of-band discussion with @alexcrichton it sounds like updating the existing builder method should be fine, so I'll put together a PR.

Wasmtime GitHub notifications bot (May 31 2024 at 21:29):

alexcrichton closed issue #8714:

Currently, the WasiCtxBuilder::socket_addr_check callback is synchronous. While this is often reasonable, I'm working on some code that wants to resolve inputs to this check asynchronously, which requires either delaying construction of the WasiCtx (which delays execution of the guest) or blocking the thread within the check.

Could this allow async callbacks? Either updating the existing signature (presumably breaking existing code, but with a trivial fix) or adding a new e.g. socket_addr_async_check method?

cc @rylev

Last updated: Nov 22 2024 at 16:03 UTC