Stream: git-wasmtime

Topic: wasmtime / issue #8712 Documentation: Outdated comment in...

Wasmtime GitHub notifications bot (May 30 2024 at 05:32):

godotdot opened issue #8712:

The issue is in the first example on this page: https://docs.rs/wasmtime/latest/wasmtime/component/macro.bindgen.html

impl HelloWorldImports for MyState {
    // Note the `Result` return value here where `Ok` is returned back to
    // the component and `Err` will raise a trap.
    fn name(&mut self) -> String {
        self.name.clone()
    }
}```
The comment wasn't changed when the code was: https://github.com/bytecodealliance/wasmtime/blob/247851234bef9af6258ed81f7d235c2865d5445a/crates/wasmtime/src/component/mod.rs#L94
~~~

Wasmtime GitHub notifications bot (May 31 2024 at 17:29):

alexcrichton edited issue #8712:

The issue is in the first example on this page: https://docs.rs/wasmtime/latest/wasmtime/component/macro.bindgen.html

impl HelloWorldImports for MyState {
    // Note the `Result` return value here where `Ok` is returned back to
    // the component and `Err` will raise a trap.
    fn name(&mut self) -> String {
        self.name.clone()
    }
}

The comment wasn't changed when the code was: https://github.com/bytecodealliance/wasmtime/blob/247851234bef9af6258ed81f7d235c2865d5445a/crates/wasmtime/src/component/mod.rs#L94

Wasmtime GitHub notifications bot (May 31 2024 at 20:52):

alexcrichton closed issue #8712:

The issue is in the first example on this page: https://docs.rs/wasmtime/latest/wasmtime/component/macro.bindgen.html

impl HelloWorldImports for MyState {
    // Note the `Result` return value here where `Ok` is returned back to
    // the component and `Err` will raise a trap.
    fn name(&mut self) -> String {
        self.name.clone()
    }
}

The comment wasn't changed when the code was: https://github.com/bytecodealliance/wasmtime/blob/247851234bef9af6258ed81f7d235c2865d5445a/crates/wasmtime/src/component/mod.rs#L94

Last updated: Nov 22 2024 at 16:03 UTC