Stream: git-wasmtime

Topic: wasmtime / issue #8603 aarch64: Add support for `fnmadd`/...

Wasmtime GitHub notifications bot (May 12 2024 at 21:28):

afonso360 added the cranelift:E-easy label to Issue #8603.

Wasmtime GitHub notifications bot (May 12 2024 at 21:28):

afonso360 added the cranelift:area:aarch64 label to Issue #8603.

Wasmtime GitHub notifications bot (May 12 2024 at 21:28):

afonso360 added the cranelift:E-compiler-easy label to Issue #8603.

Wasmtime GitHub notifications bot (May 12 2024 at 21:28):

afonso360 opened issue #8603:

:wave: Hey,

Feature

Add support for the fnmadd / fmsub / fnmsub instructions in the aarch64 backend.

Benefit

This improves instruction selection quality for a few special fma cases.

Implementation

We already have support for the scalar fmadd instruction here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.

Something similar was done in #8588 for the RISC-V backend.

Wasmtime GitHub notifications bot (May 12 2024 at 21:29):

afonso360 edited issue #8603:

:wave: Hey,

Feature

Add support for the fnmadd / fmsub / fnmsub instructions in the aarch64 backend.

Benefit

This improves instruction selection quality for a few special fma cases.

Implementation

We already have support for the scalar fmadd instruction here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.

Something similar was done in #8588 for the RISC-V backend. If anyone needs help implementing this, let me know!

Wasmtime GitHub notifications bot (Oct 05 2024 at 19:18):

aidenfoxivey commented on issue #8603:

@afonso360 Seems like this issue is solved.

Wasmtime GitHub notifications bot (Oct 05 2024 at 19:31):

afonso360 closed issue #8603:

:wave: Hey,

Feature

Add support for the fnmadd / fmsub / fnmsub instructions in the aarch64 backend.

Benefit

This improves instruction selection quality for a few special fma cases.

Implementation

We already have support for the scalar fmadd instruction here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.

Something similar was done in #8588 for the RISC-V backend. If anyone needs help implementing this, let me know!

Wasmtime GitHub notifications bot (Oct 05 2024 at 19:31):

afonso360 commented on issue #8603:

That's right, thanks for letting me know!

Last updated: Nov 22 2024 at 17:03 UTC