Wasmtime GitHub notifications bot (May 12 2024 at 21:17): Wasmtime GitHub notifications bot (May 12 2024 at 21:17):afonso360 added the cranelift:E-easy label to Issue #8602.
Wasmtime GitHub notifications bot (May 12 2024 at 21:17):afonso360 added the cranelift:E-compiler-easy label to Issue #8602.
Wasmtime GitHub notifications bot (May 12 2024 at 21:17):afonso360 added the cranelift:area:x64 label to Issue #8602.
Wasmtime GitHub notifications bot (May 12 2024 at 21:17):afonso360 opened issue #8602:
:wave: Hey,
Feature
Add support for the
fmsubandfnmsubinstructions in the x64 backend.Benefit
This improves instruction selection quality for a few special fma cases.
Implementation
We already have support for the
fmaddandfnmaddversions of these instructions here and here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.Something similar was done in #8588 for the RISC-V backend.
Wasmtime GitHub notifications bot (May 12 2024 at 21:18):afonso360 edited issue #8602:
:wave: Hey,
Feature
Add support for the
fmsubandfnmsubinstructions in the x64 backend.Benefit
This improves instruction selection quality for a few special fma cases.
Implementation
We already have support for the
fmaddandfnmaddversions of these instructions here and here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.Something similar was done in #8588 for the RISC-V backend.
Wasmtime GitHub notifications bot (May 12 2024 at 21:19):afonso360 edited issue #8602:
:wave: Hey,
Feature
Add support for the
fmsubandfnmsubinstructions in the x64 backend.Benefit
This improves instruction selection quality for a few special fma cases.
Implementation
We already have support for the
fmaddandfnmaddversions of these instructions here and here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.Something similar was done in #8588 for the RISC-V backend.
Wasmtime GitHub notifications bot (May 12 2024 at 21:29):afonso360 edited issue #8602:
:wave: Hey,
Feature
Add support for the
fmsubandfnmsubinstructions in the x64 backend.Benefit
This improves instruction selection quality for a few special fma cases.
Implementation
We already have support for the
fmaddandfnmaddversions of these instructions here and here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.Something similar was done in #8588 for the RISC-V backend. If anyone needs help implementing this, let me know!
Wasmtime GitHub notifications bot (May 13 2024 at 16:49):UnlimitedHummus commented on issue #8602:
Hey, I would like to try to implement this. I might need some help, as this is my first contribution.
If I have questions, should I ask them here or in Zulip?
Wasmtime GitHub notifications bot (May 13 2024 at 17:30):afonso360 commented on issue #8602:
Awesome! :tada:
If I have questions, should I ask them here or in Zulip?
Up to you, I'm available in both. I might be able to give you a faster reply on Zulip since that usually sends me a notification.
Wasmtime GitHub notifications bot (Oct 05 2024 at 20:37):aidenfoxivey commented on issue #8602:
@afonso360 Seems the same here - also complete.
Wasmtime GitHub notifications bot (Oct 05 2024 at 20:51):afonso360 closed issue #8602:
:wave: Hey,
Feature
Add support for the
fmsubandfnmsubinstructions in the x64 backend.Benefit
This improves instruction selection quality for a few special fma cases.
Implementation
We already have support for the
fmaddandfnmaddversions of these instructions here and here. So we adding support for these instructions should be a matter of introducing the new opcodes and implementing lowering rules similar to what already exists today.Something similar was done in #8588 for the RISC-V backend. If anyone needs help implementing this, let me know!
Last updated: Dec 23 2024 at 12:05 UTC