Stream: git-wasmtime

Topic: wasmtime / issue #8424 Remove the automatic ISA assumptio...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 18:31):

lambdadeltakay opened issue #8424:

Feature

Allow for specifiying no ISA targets and not failing to compile in the build.rs when no ISA targets are specified on a unsupported platform for code generation on cranelift-codegen

Benefit

This would allow for using cranelift-codegen related utilities on platforms like wasm or powerpc.

Implementation

This would require just removing the code in the build.rs that assumes the ISA target for generation when no ISA targets are specified

Alternatives

A possible alternative would be a feature flag that would specify that no ISA targets should be built in

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 18:33):

lambdadeltakay edited issue #8424:

Feature

Allow for specifiying no ISA targets and not failing to compile in the build.rs when no ISA targets are specified on a unsupported platform for code generation on cranelift-codegen

Benefit

This would allow for using cranelift related utilities on platforms like wasm or powerpc.

Implementation

This would require just removing the code in the build.rs that assumes the ISA target for generation when no ISA targets are specified

Alternatives

A possible alternative would be a feature flag that would specify that no ISA targets should be built in

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 19:04):

bjorn3 commented on issue #8424:

I believe disabling the host-arch feature of cranelift-codegen will already do this.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 19:10):

lambdadeltakay commented on issue #8424:

https://github.com/bytecodealliance/wasmtime/blob/1fa8de140fce161ed5d77cf939558de79d3956c1/cranelift/codegen/build.rs#L42-L51

From my experiments and these lines of code it doesn't seem to do this, instead I have to manually set at least one ISA that doesn't relate to the target to avoid a compile error


Last updated: Oct 23 2024 at 20:03 UTC