Stream: git-wasmtime

Topic: wasmtime / issue #8413 `wasmtime-environ` fuzz targets no...

Wasmtime GitHub notifications bot (Apr 19 2024 at 16:29):

fitzgen opened issue #8413:

It looks like we aren't checking them in CI. They no longer build. @alexcrichton informs me it would be better to fix them, and start checking them in CI, than to simply remove them (even though I don't expect we will want to run them on OSS-Fuzz, just have the option for local devs to run them, similar to our ISLE fuzz targets).

Need to fix the cargo features first:

modified   crates/environ/fuzz/Cargo.toml
@@ -21,9 +21,9 @@ component-fuzz-util = { workspace = true, optional = true }
 [[bin]]
 name = "fact-valid-module"
 path = "fuzz_targets/fact-valid-module.rs"
 test = false
 doc = false
 required-features = ["component-model"]

 [features]
-component-model = ["wasmtime-environ/component-model", "dep:component-fuzz-util"]
+component-model = ["wasmtime-environ/component-model", "wasmtime-environ/compile", "dep:component-fuzz-util"]

And then you can see the rest of the errors with

$ cargo fuzz check -s none --fuzz-dir crates/environ/fuzz

Wasmtime GitHub notifications bot (Apr 22 2024 at 19:44):

fitzgen closed issue #8413:

It looks like we aren't checking them in CI. They no longer build. @alexcrichton informs me it would be better to fix them, and start checking them in CI, than to simply remove them (even though I don't expect we will want to run them on OSS-Fuzz, just have the option for local devs to run them, similar to our ISLE fuzz targets).

Need to fix the cargo features first:

modified   crates/environ/fuzz/Cargo.toml
@@ -21,9 +21,9 @@ component-fuzz-util = { workspace = true, optional = true }
 [[bin]]
 name = "fact-valid-module"
 path = "fuzz_targets/fact-valid-module.rs"
 test = false
 doc = false
 required-features = ["component-model"]

 [features]
-component-model = ["wasmtime-environ/component-model", "dep:component-fuzz-util"]
+component-model = ["wasmtime-environ/component-model", "wasmtime-environ/compile", "dep:component-fuzz-util"]

And then you can see the rest of the errors with

$ cargo fuzz check -s none --fuzz-dir crates/environ/fuzz

Last updated: Nov 22 2024 at 16:03 UTC