Stream: git-wasmtime

Topic: wasmtime / issue #8188 Async flavor of `wasmtime_wasi_htt...

Wasmtime GitHub notifications bot (Mar 20 2024 at 13:07):

rylev opened issue #8188:

The wasi:http/proxy world contains a subset of wasi imports found in the wasi:cli/command world. wasmtime_wasi_http::proxy::add_to_linker seems to do the right thing and only link the wasi interfaces that the world says it imports. However, wasmtime_wasi_http::proxy::sync::add_to_linker simply wholesale imports the entire command world.

There is a TODO stating that this is due to the adapter bringing in all of these imports along with a hidden function that only brings in the required imports. I'm unsure if this is all still needed for if this can be corrected. However, at the very least, this can be very confusing for users, and we should at least have some sort of documentation pointing out that this will happen.

Wasmtime GitHub notifications bot (Mar 28 2024 at 03:31):

alexcrichton closed issue #8188:

The wasi:http/proxy world contains a subset of wasi imports found in the wasi:cli/command world. wasmtime_wasi_http::proxy::add_to_linker seems to do the right thing and only link the wasi interfaces that the world says it imports. However, wasmtime_wasi_http::proxy::sync::add_to_linker simply wholesale imports the entire command world.

There is a TODO stating that this is due to the adapter bringing in all of these imports along with a hidden function that only brings in the required imports. I'm unsure if this is all still needed for if this can be corrected. However, at the very least, this can be very confusing for users, and we should at least have some sort of documentation pointing out that this will happen.

Last updated: Nov 22 2024 at 16:03 UTC