Stream: git-wasmtime

Topic: wasmtime / issue #8104 `connect_timeout` is used twice in...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 17:51):

elliottt added the bug label to Issue #8104.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 17:51):

elliottt opened issue #8104:

As mentioned in #8085, the connect_timeout is used to timeout both the initial tcp connection, and the handshake result from hyper. We likely only need the first timeout on the tcp connection, but it would be good to validate this.

Concretely, we can probably remove the timeout uses from these two places in types.rs:

https://github.com/bytecodealliance/wasmtime/blob/d27fc3d001050a93e903bb76ac5551fbc5480566/crates/wasi-http/src/types.rs#L207-L212

https://github.com/bytecodealliance/wasmtime/blob/d27fc3d001050a93e903bb76ac5551fbc5480566/crates/wasi-http/src/types.rs#L228-L234

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2024 at 17:54):

elliottt added the wasi:impl label to Issue #8104.


Last updated: Oct 23 2024 at 20:03 UTC