Stream: git-wasmtime

Topic: wasmtime / issue #7685 trace-log feature does not take ef...

Wasmtime GitHub notifications bot (Dec 14 2023 at 06:46):

feilongjiang opened issue #7685:

#7626 changed the cranelift-codegen features from default to host-arch in crates/cranelift/Cargo.toml.

Before this change, I could enable trace by adding trace-log to features in cranelift/codegen/Cargo.toml.

But now the old way doesn't work, trace-log should be added to crates/cranelift/Cargo.toml like this::

cranelift-codegen = { workspace = true, features = ["host-arch", "trace-log"] }
````
is that expected behavior?


~~~

Wasmtime GitHub notifications bot (Dec 14 2023 at 06:48):

feilongjiang edited issue #7685:

#7626 changed the cranelift-codegen features from default to host-arch in crates/cranelift/Cargo.toml.

Before this change, I could enable trace by adding trace-log to features in cranelift/codegen/Cargo.toml.

But now the old way doesn't work, trace-log should be added to crates/cranelift/Cargo.toml like this:

cranelift-codegen = { workspace = true, features = ["host-arch", "trace-log"] }
````
is that expected behavior?


~~~

Wasmtime GitHub notifications bot (Dec 14 2023 at 07:05):

feilongjiang edited issue #7685:

#7626 changed the cranelift-codegen features from default to host-arch in crates/cranelift/Cargo.toml.

Before this change, I could enable trace by adding trace-log to the features' default list in cranelift/codegen/Cargo.toml.

But now the old way doesn't work, trace-log should be added to crates/cranelift/Cargo.toml like this:

cranelift-codegen = { workspace = true, features = ["host-arch", "trace-log"] }
````
is that expected behavior?


~~~

Wasmtime GitHub notifications bot (Dec 14 2023 at 16:01):

alexcrichton commented on issue #7685:

This is expected behavior in that it's how Cargo features work, but not necessarily expected behavior in that's how things are expected to work. The best solution here would probably be to add a cranelift-trace-log feature to the wasmtime crate and thread that through

Wasmtime GitHub notifications bot (Jan 04 2024 at 05:48):

feilongjiang closed issue #7685:

#7626 changed the cranelift-codegen features from default to host-arch in crates/cranelift/Cargo.toml.

Before this change, I could enable trace by adding trace-log to the features' default list in cranelift/codegen/Cargo.toml.

But now the old way doesn't work, trace-log should be added to crates/cranelift/Cargo.toml like this:

cranelift-codegen = { workspace = true, features = ["host-arch", "trace-log"] }
````
is that expected behavior?


~~~

Last updated: Nov 22 2024 at 16:03 UTC