Stream: git-wasmtime

Topic: wasmtime / issue #7588 Eagerly cast pointers in aarch64 r...

Wasmtime GitHub notifications bot (Nov 27 2023 at 22:02):

elliottt opened issue #7588:

When performing relocations in cranelift-jit, there are many introductions of a variable what that's defined as an unsafe pointer offset. These variables are almost always cast to usize or isize before they're used, so perhaps we should instead turn the base pointer into its target numeric type eagerly, to avoid needing the unsafe blocks for calling the offset method on the pointers.

https://github.com/bytecodealliance/wasmtime/blob/cd97c9f14713d81de5453fb9861319e78a761432/cranelift/jit/src/compiled_blob.rs#L55-L57

Wasmtime GitHub notifications bot (Nov 28 2023 at 00:44):

bjorn3 commented on issue #7588:

Using wrapping_offset it also an option. On CHERI you would need to use the current code to preserve the pointer capability I think, but we don't support CHERI yet anyway.

Wasmtime GitHub notifications bot (Nov 28 2023 at 00:49):

elliottt added the good first issue label to Issue #7588.

Wasmtime GitHub notifications bot (Sep 10 2024 at 21:50):

sudoHackIn commented on issue #7588:

Hi, @elliottt @bjorn3,is this issue is still actual? Unfortunately from glaziermag's pr and this comment (https://github.com/bytecodealliance/wasmtime/pull/8041#discussion_r1509922915) i cannot understand, whether pr is not correct, or bjorn3 decided that any modification(about this issue) doesn't make sense at all

Last updated: Nov 22 2024 at 16:03 UTC