Stream: git-wasmtime

Topic: wasmtime / issue #7580 Add riscv-64 to the supported arch...

Wasmtime GitHub notifications bot (Nov 24 2023 at 10:35):

afro-coder edited issue #7580:

Thanks for filing a feature request! Please fill out the TODOs below.

Feature

TODO: Brief description of the feature/improvement you'd like to see in
Cranelift/Wasmtime.

The install script currently doesn't allow me to install a riscv-64 program

Benefit

TODO: What is the value of adding this in Cranelift/Wasmtime? What problems does
it solve?

Ease of installation for riscv devices

Implementation

TODO: Do you have an implementation plan, and/or ideas for data structures or
algorithms to use?

I'm unable to locate the install script curl https://wasmtime.dev/install.sh -sSf | bash

Alternatives

TODO: What are the alternative implementation approaches or alternative ways to
solve the problem that this feature would solve? How do these alternatives
compare to this proposal?

Wasmtime GitHub notifications bot (Nov 24 2023 at 12:11):

afonso360 commented on issue #7580:

I started working on this. Updating the script was fairly easy. However I've ran into an issue with the arch name being different in the releases vs what the OS identifies locally.

Locally I'm running Debian 13 (trixie), and uname -m identifies the architecture as riscv64, but on our release binaries we tag them as riscv64gc, which is the target triple name for our target.

I'm not entirely sure where we should fix this. Do we update our release names, or should I try to fix this up in the script? (cc: @alexcrichton)

Wasmtime GitHub notifications bot (Nov 24 2023 at 12:16):

afonso360 edited a comment on issue #7580:

I started working on this. Updating the script was fairly easy. However I've ran into an issue with the arch name being different in the releases vs what the OS identifies locally.

Locally I'm running Debian 13 (trixie), and uname -m identifies the architecture as riscv64, but on our release binaries we tag them as riscv64gc, which is the target triple name for our target.

This causes the script to attempt to download a file that does not exist.

I'm not entirely sure where we should fix this. Do we update our release names, or should I try to fix this up in the script? (cc: @alexcrichton)

Wasmtime GitHub notifications bot (Nov 24 2023 at 12:21):

afro-coder commented on issue #7580:

Hi, thanks for making that change, where is the script located to make these changes?

Wasmtime GitHub notifications bot (Nov 24 2023 at 12:30):

bjorn3 commented on issue #7580:

https://github.com/bytecodealliance/wasmtime.dev/blob/gh-pages/install.sh

Wasmtime GitHub notifications bot (Nov 27 2023 at 04:20):

alexcrichton commented on issue #7580:

I'd probably recommend a case / esac statement which canonicalizes known architecture names that distros print into the architecture names that we expect in Wasmtime. We can try to match distros but I suspect we'll inevitably get things wrong (like this) or one distro won't match another (no known case yet), so having a pass where we inspect uname and go from there is probably the way to go.

Wasmtime GitHub notifications bot (Dec 01 2023 at 15:47):

alexcrichton closed issue #7580:

Thanks for filing a feature request! Please fill out the TODOs below.

Feature

TODO: Brief description of the feature/improvement you'd like to see in
Cranelift/Wasmtime.

The install script currently doesn't allow me to install a riscv-64 program

Benefit

TODO: What is the value of adding this in Cranelift/Wasmtime? What problems does
it solve?

Ease of installation for riscv devices

Implementation

TODO: Do you have an implementation plan, and/or ideas for data structures or
algorithms to use?

I'm unable to locate the install script curl https://wasmtime.dev/install.sh -sSf | bash

Alternatives

TODO: What are the alternative implementation approaches or alternative ways to
solve the problem that this feature would solve? How do these alternatives
compare to this proposal?

Last updated: Nov 22 2024 at 16:03 UTC