Stream: git-wasmtime

Topic: wasmtime / issue #7477 feat(wasmtime/component): add `Lin...

Wasmtime GitHub notifications bot (Nov 03 2023 at 17:49):

alexcrichton commented on issue #7477:

Thanks!

Wasmtime GitHub notifications bot (Nov 03 2023 at 18:35):

rvolosatovs commented on issue #7477:

@alexcrichton apologies, I missed the async feature in previous iteration - added

    #[cfg(feature = "async")]
    #[cfg_attr(nightlydoc, doc(cfg(feature = "async")))]

just like https://github.com/bytecodealliance/wasmtime/blob/40adf87cd37ebb426aed4497cf44c9a0efc5e635/crates/wasmtime/src/component/linker.rs#L306-L307

Could you take another look?

Wasmtime GitHub notifications bot (Nov 03 2023 at 18:35):

rvolosatovs edited a comment on issue #7477:

@alexcrichton apologies, I missed the async feature in previous iteration - added

    #[cfg(feature = "async")]
    #[cfg_attr(nightlydoc, doc(cfg(feature = "async")))]

just like https://github.com/bytecodealliance/wasmtime/blob/40adf87cd37ebb426aed4497cf44c9a0efc5e635/crates/wasmtime/src/component/linker.rs#L306-L307

Could you take another look?

Wasmtime GitHub notifications bot (Nov 03 2023 at 19:45):

github-actions[bot] commented on issue #7477:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 17:03 UTC