Stream: git-wasmtime

Topic: wasmtime / issue #7467 There is another bug in "invoke_fu...

Wasmtime GitHub notifications bot (Nov 03 2023 at 02:53):

liutao-liu added the bug label to Issue #7467.

Wasmtime GitHub notifications bot (Nov 03 2023 at 02:53):

liutao-liu opened issue #7467:

Similar to this issue, nan:0x200000 and -nan:0x200000 cannot be parsed, and the same error message "invalid float literal" is reported.

In addition, -nan is parsed into nan, which is incorrect. nan and-nan represent different meanings, and their bits are different.

Wasmtime GitHub notifications bot (Nov 03 2023 at 03:06):

liutao-liu edited issue #7467:

Similar to this issue, nan:0x200000 and -nan:0x200000 cannot be parsed, and the same error message "invalid float literal" is reported.

In addition, -nan is parsed into nan, which is incorrect. nan and-nan represent different meanings, and their bits are different.

Wasmtime GitHub notifications bot (Nov 03 2023 at 16:23):

alexcrichton commented on issue #7467:

Yes this is expected as the CLI uses the Rust standard libray to parse floats right now, which is not the same as the text format of WebAssembly.

Wasmtime GitHub notifications bot (Nov 04 2023 at 07:54):

liutao-liu commented on issue #7467:

Yes this is expected as the CLI uses the Rust standard libray to parse floats right now, which is not the same as the text format of WebAssembly.

Is that going to fix the problem?

Wasmtime GitHub notifications bot (Nov 06 2023 at 17:00):

alexcrichton commented on issue #7467:

Sorry I'm not sure if I understand your question?

To clarify what I'm saying, the parsing of f32/f64 in the CLI isn't specified right now in Wasmtime and it's "whatever rust libstd happens to implement". The syntax you're describing here I think is probably coming from the text format of WebAssembly, however, which isn't plumbed into this part of Wasmtime right now. Assuming you want the same text format of WebAssembly then yes I believe that will resolve this issue.

Wasmtime GitHub notifications bot (Nov 07 2023 at 01:34):

liutao-liu commented on issue #7467:

Yes brother, I shouldn't describe it as a problem, this format is from webAssembly. It would be great if wasmtime should support this format in the future.

Wasmtime GitHub notifications bot (Nov 09 2023 at 01:18):

liutao-liu closed issue #7467:

Similar to this issue, nan:0x200000 and -nan:0x200000 cannot be parsed, and the same error message "invalid float literal" is reported.

In addition, -nan is parsed into nan, which is incorrect. nan and-nan represent different meanings, and their bits are different.

Last updated: Nov 22 2024 at 16:03 UTC