badeend commented on issue #7373:
Don't have time to dive into this right now, but my initial instinct is that the test is correct. I.e.
no_delay
_should_ be false by default.Was this error part of a CI run? Does this fail consistently?
alexcrichton commented on issue #7373:
Yeah failure was in a CI run and definitely doesn't fail consistently since we've had lots of CI runs pass. Locally running it in a loop for awhile couldn't reproduce. The failure was on Windows MinGW, although I'm not sure if it's Windows-specific.
If you'd like we could wait and see if it fails again perhaps to collect some more data.
badeend commented on issue #7373:
I've created a tracking issue for this at https://github.com/WebAssembly/wasi-sockets/issues/67
I'm in favor of holding off these changes and waiting to see how often this happens. If more than once, this should be investigated more thoroughly.
alexcrichton commented on issue #7373:
Ok sounds good :+1:
Last updated: Dec 23 2024 at 12:05 UTC