Stream: git-wasmtime

Topic: wasmtime / issue #7373 Relax no_delay assertion in tcp so...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 20:49):

badeend commented on issue #7373:

Don't have time to dive into this right now, but my initial instinct is that the test is correct. I.e. no_delay _should_ be false by default.

Was this error part of a CI run? Does this fail consistently?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 20:58):

alexcrichton commented on issue #7373:

Yeah failure was in a CI run and definitely doesn't fail consistently since we've had lots of CI runs pass. Locally running it in a loop for awhile couldn't reproduce. The failure was on Windows MinGW, although I'm not sure if it's Windows-specific.

If you'd like we could wait and see if it fails again perhaps to collect some more data.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:12):

badeend commented on issue #7373:

I've created a tracking issue for this at https://github.com/WebAssembly/wasi-sockets/issues/67

I'm in favor of holding off these changes and waiting to see how often this happens. If more than once, this should be investigated more thoroughly.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:24):

alexcrichton commented on issue #7373:

Ok sounds good :+1:

Last updated: Nov 22 2024 at 17:03 UTC