Stream: git-wasmtime

Topic: wasmtime / issue #7369 Allow disabling the host-arch feat...

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:26):

bjorn3 commented on issue #7369:

Without the unwind feature enabled I get:

error[E0433]: failed to resolve: could not find `systemv` in `unwind`
    --> cranelift/codegen/src/machinst/vcode.rs:1181:41
     |
1181 |                     crate::isa::unwind::systemv::caller_sp_to_cfa_offset();
     |                                         ^^^^^^^ could not find `systemv` in `unwind`

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:27):

bjorn3 commented on issue #7369:

It would be great if this could get backported too. Without this rust's CI fails when trying to build cg_clif for distribution with rustup.

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:31):

alexcrichton commented on issue #7369:

Thanks! I'm a little surprised that the dependency from wasmtime-cranelift on the cranelift crate, without features = ['default'], still works. I think it's because without any enabled ISAs it still builds the host ISA? Mind adding it there though to be safe?

Otherwise yeah looks like disabling the unwind feature and not being able to compile is indeed a Cranelift bug. If you'd like feel free to open an issue (or a subsequent PR) to fix that. Enabling it here by default is definitely ok.

Also a point release is fine by me, and there's one slated tomorrow for https://github.com/bytecodealliance/wasmtime/pull/7362 as well so good timing!

If you wouldn't mind preparing the PR for the backport that'd be appreciated!

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:35):

bjorn3 commented on issue #7369:

Mind adding it there though to be safe?

Done

If you'd like feel free to open an issue (or a subsequent PR) to fix that.

Sure

If you wouldn't mind preparing the PR for the backport that'd be appreciated!

Will do.

Last updated: Nov 22 2024 at 16:03 UTC