Stream: git-wasmtime

Topic: wasmtime / issue #7301 Swap the order of directories in `...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 23:31):

sunfishcode commented on issue #7301:

Matching docker makes sense to me too. As a historical note, the original syntax here wasn't something anyone thought about deeply, it was just something simple to get basic use cases working, that ended up sticking around.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2023 at 23:48):

jeffparsons commented on issue #7301:

Is there a way this arg could be extended in future (in a backward-compatible way) to support an optional verbose form? E.g. --dir host=a;guest=b, or even --dir host=a guest=b, where you can put host and guest in whatever order you want?

I'm trying to think through how the delimiters/escaping would work, and I realised I don't understand how it works today — e.g. what happens if your path contains ::. Is the answer "don't have silly paths"? :sweat_smile:

I ask this because these kinds of order-dependent syntaxes (Docker volume mounts, SSH port forwarding, etc.) have caused me seemingly endless confusion and suffering, and I'm not sure if I'm uniquely vulnerable to them or if this is something that lots of other people would like to be able to avoid as well.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 20 2023 at 00:14):

alexcrichton commented on issue #7301:

I personally agree with @jeffparsons, although it's a bit too late for Wasmtime 14/15 to change the syntax here that much. This at least makes things "no worse" on the understandability front hopefully.

I've opened https://github.com/bytecodealliance/wasmtime/issues/7309 to continue discussion here now that this is merged, since I think there are still improvements to be had!


Last updated: Nov 22 2024 at 16:03 UTC