Stream: git-wasmtime

Topic: wasmtime / issue #7261 Add accessors and mutators for all...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 20:55):

tschneidereit commented on issue #7261:

I'll ensure that both copies of the wit files are in sync once I've worked through any feedback

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 22:55):

pchickey commented on issue #7261:

This is much easier to accept than #7260 which I think we want to see a tested implementation for in order to land. b663ccf, on the other hand, is trivial. Can you rebase this PR to be just that commit?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 22:55):

pchickey edited a comment on issue #7261:

This is much easier to accept than #7260 which I think we want to see a tested implementation for in order to land. b663ccf, on the other hand, is trivial. Can you rebase this PR to be just that commit, and provide an implementation?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2023 at 23:57):

pchickey commented on issue #7261:

I sent this upstream as https://github.com/WebAssembly/wasi-http/pull/65, I'll work on an implementation in another PR

view this post on Zulip Wasmtime GitHub notifications bot (Oct 31 2023 at 17:30):

elliottt commented on issue #7261:

I think this is redundant with main now, as we've implemented the upstreamed mutators. Do you mind if we close this PR @tschneidereit ?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2023 at 18:50):

alexcrichton commented on issue #7261:

I'm going to close this due to @elliottt's prior comment and the main changes having been incorporated.

Last updated: Nov 22 2024 at 17:03 UTC