Stream: git-wasmtime

Topic: wasmtime / issue #7252 riscv64: Implement some `Zbs` exte...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 16 2023 at 16:44):

github-actions[bot] commented on issue #7252:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 17 2023 at 15:06):

alexcrichton commented on issue #7252:

I'm not sure if these are really all that common enough in practice to warrant new CLIF instructions, especially given that the lowerings aren't too bad to have, but it's also true though that if every platform has a variation of this then it might be reasonable to add.

I do think though that the suite of instructions on x64 is different than on riscv64, for example riscv64 has more immediate-related instructions because on x64 you can fit an entire 32-bit immediate into an instruction but you can't do that on riscv64. That means that bclri is motivated on riscv64 (or at least that's my inference as to the assumption), whereas on x64 there's only the bclr equivalent (or roughly speaking I think)


Last updated: Nov 22 2024 at 16:03 UTC