Wasmtime GitHub notifications bot (Oct 05 2023 at 02:28): Wasmtime GitHub notifications bot (Oct 05 2023 at 02:28):jeffparsons commented on issue #7148:
Is this meant to support broadcast? I couldn't find any mention of it in the spec (maybe I just wasn't looking properly?) so I'm wondering whether this is just a question of whether the host is configured to allow
the guest to send to a broadcast address.
Wasmtime GitHub notifications bot (Oct 05 2023 at 10:48):rvolosatovs commented on issue #7148:
Is this meant to support broadcast? I couldn't find any mention of it in the spec (maybe I just wasn't looking properly?) so I'm wondering whether this is just a question of whether the host is configured to allow the guest to send to a broadcast address.
I feel like this is something that belongs in https://github.com/WebAssembly/wasi-sockets/blob/main/wit/udp.wit, e.g.
set-broadcastmethod onudp-socket
Wasmtime GitHub notifications bot (Oct 05 2023 at 15:02):alexcrichton commented on issue #7148:
I might also recommend opening an issue on https://github.com/WebAssembly/wasi-sockets/issues for support if you're interested
Wasmtime GitHub notifications bot (Oct 06 2023 at 18:40):rvolosatovs commented on issue #7148:
@alexcrichton I believe I've addressed everything apart from the https://github.com/bytecodealliance/wasmtime/pull/7148#discussion_r1348810978
Wasmtime GitHub notifications bot (Oct 06 2023 at 20:50):rvolosatovs commented on issue #7148:
Any idea what went wrong with the merge? Did I miss something?
Wasmtime GitHub notifications bot (Oct 06 2023 at 20:53):rvolosatovs edited a comment on issue #7148:
Any idea what went wrong with the merge? Did I miss something?
Update: I see it now https://github.com/bytecodealliance/wasmtime/actions/runs/6435495256/job/17476888343#step:13:1
I'm away from my laptop already, but I will fix it as soon as I'm back
Wasmtime GitHub notifications bot (Oct 06 2023 at 23:03):rvolosatovs commented on issue #7148:
@alexcrichton this should be good to merge now
Wasmtime GitHub notifications bot (Oct 06 2023 at 23:47):rvolosatovs commented on issue #7148:
Ah, looks like there's also a wit syntax change to address after a rebase
Wasmtime GitHub notifications bot (Oct 07 2023 at 13:16):rvolosatovs commented on issue #7148:
Rebased/updated yet again
Wasmtime GitHub notifications bot (Oct 08 2023 at 15:23):badeend commented on issue #7148:
Apologies for the late comment, I just noticed this PR.
- Why does
start_connectperform an explicit bind to0.0.0.0:0? This shouldn't be necessary. The first call toconnectwill implicitly bind the socket for you, right?- On UDP sockets, the native
connectcall doesn't perform any IO and always succeeds or fails synchronously. It never returns EINPROGRESS. I suspect you can drop a lot of complexity instart_connect&finish_connect.I have the changes ready to go if you want: https://github.com/rvolosatovs/wasmtime/pull/1
Wasmtime GitHub notifications bot (Oct 08 2023 at 15:27):rvolosatovs commented on issue #7148:
Apologies for the late comment, I just noticed this PR.
- Why does
start_connectperform an explicit bind to0.0.0.0:0? This shouldn't be necessary. The first call toconnectwill implicitly bind the socket for you, right?- On UDP sockets, the native
connectcall doesn't perform any IO and always succeeds or fails synchronously. It never returns EINPROGRESS. I suspect you can drop a lot of complexity instart_connect&finish_connect.I have the changes ready to go if you want: https://github.com/rvolosatovs/wasmtime/pull/1
Thank you, integrated into this PR!
Wasmtime GitHub notifications bot (Oct 09 2023 at 05:08):badeend commented on issue #7148:
#7120 was just merged and is causing some conflicts with this one. I've resolved them for you in https://github.com/rvolosatovs/wasmtime/pull/2. Also I've revised the test case; that may help with the CI failure.
Wasmtime GitHub notifications bot (Oct 09 2023 at 07:42):rvolosatovs commented on issue #7148:
@badeend thank you for working on this. Yes, my initial thought was to wait for #7120 actually, but back then it was not ready for merge, and I hoped to get this one in quick (which did not really work out as planned)
I've integrated your changes
Wasmtime GitHub notifications bot (Oct 09 2023 at 07:42):rvolosatovs edited a comment on issue #7148:
@badeend thank you for working on this. Yes, my initial thought was to wait for #7120 actually, but back then it was not ready for merge, and I hoped to get this one in quick (which did not really work out as planned)
I've integrated and tested your changes
Last updated: Nov 22 2024 at 17:03 UTC