Stream: git-wasmtime

Topic: wasmtime / issue #7120 wasi-sockets: Simplify & clarify T...

Wasmtime GitHub notifications bot (Oct 02 2023 at 16:30):

alexcrichton commented on issue #7120:

Given the crop of new tests I might recommend pushing a commit with prtest:full in the commit message to run full CI on this PR ahead of the merge queue, as this likely runs a risk of needing fixes for platform compatibility and such.

Wasmtime GitHub notifications bot (Oct 02 2023 at 16:30):

alexcrichton commented on issue #7120:

(also thank you so much for writing these tests, it's very much appreciated!)

Wasmtime GitHub notifications bot (Oct 03 2023 at 15:08):

alexcrichton commented on issue #7120:

Ah yeah looks like there's some issues on macOS at least. If you need help debugging I can see if I can pitch in, otherwise let me know when this is ready and I'll review for merge

Wasmtime GitHub notifications bot (Oct 03 2023 at 15:49):

badeend commented on issue #7120:

I think I already know what the issue is. Do you know if there is any way for me (a non-Mac user) to test this, other than committing the change and praying that half an hour later the CI doesn't fail? :stuck_out_tongue:

Wasmtime GitHub notifications bot (Oct 03 2023 at 15:50):

badeend commented on issue #7120:

Or is there a way to trigger just the MacOS CI?

Wasmtime GitHub notifications bot (Oct 03 2023 at 15:53):

alexcrichton commented on issue #7120:

This is the script that determines what to run in CI, but running just macOS won't affect too much as it should start immediately. We should have enough parallelism on the org to run all builds each time, so no worries on that.

Otherwise one thing you can do is to edit CI to just run your single test (e.g. update ./ci/run-tests.sh with a cargo test for just the test you're intersted in). Overall though it's unfortunately not fun debugging on hardware you don't have access to locally :(

Wasmtime GitHub notifications bot (Oct 08 2023 at 14:56):

badeend commented on issue #7120:

@alexcrichton All tests turned green. I think this is ready for review now.

Last updated: Nov 22 2024 at 16:03 UTC