Wasmtime GitHub notifications bot (Sep 29 2023 at 15:04): Wasmtime GitHub notifications bot (Sep 29 2023 at 15:04):alexcrichton commented on issue #7112:
cc @RubixDev and @maxbrunsfeld on this. I'd want to confirm that your embedding use case still works if this is removed. Additionally this is mostly just pointing out that it's not necessary to have this directive to get things working. That being said I can imagine it's still convenient to have because you'd only need one Cargo manifest directive instead of two.
If y'all would prefer I think it would make sense to keep this but as
pub use wasmtimeinstead ofpub use wasmtime::*so you could access all of the internals but it wouldn't clash namespaces ideally. In any case I'd like to leavemainas-is until y'all have weighed in over here.
Wasmtime GitHub notifications bot (Sep 29 2023 at 17:44):github-actions[bot] commented on issue #7112:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 29 2023 at 20:00):maxbrunsfeld commented on issue #7112:
I like the idea of
pub use wasmtime, but either solution is ok with me. Our use case is pretty niche.
Last updated: Nov 22 2024 at 16:03 UTC