Wasmtime GitHub notifications bot (Sep 28 2023 at 19:29): Wasmtime GitHub notifications bot (Sep 28 2023 at 19:29):rockwotj commented on issue #7106:
Force pushes:
- 80f792e to dbe918a: Fix cargo formatting
- dbe918a to a836f5e: Make sure --no-default-features still builds cleanly
Wasmtime GitHub notifications bot (Sep 28 2023 at 19:47):rockwotj commented on issue #7106:
Force push a836f5e to f7aa8c5: Add more comments to async example.
Wasmtime GitHub notifications bot (Sep 28 2023 at 22:44):github-actions[bot] commented on issue #7106:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Oct 02 2023 at 20:37):rockwotj commented on issue #7106:
Thanks for working with me on this one!
Wasmtime GitHub notifications bot (Oct 03 2023 at 00:20):rockwotj commented on issue #7106:
It looks like the MacOS runner uses C++11 by default (although maybe it supports later versions of C++ from the error messages). I decided to just downgrade the example to C++11 and explicitly call that out in CMakeLists.txt, that should fix the CI.
Wasmtime GitHub notifications bot (Oct 03 2023 at 01:55):alexcrichton commented on issue #7106:
If you'd like you can push up a commit with "prtest:full" somewhere in the message and it'll run full CI on this PR before merging
Wasmtime GitHub notifications bot (Oct 03 2023 at 03:07):rockwotj commented on issue #7106:
Thanks for the tip, looks like I was just missing a header for clang on MacOS. Looking good now.
Last updated: Nov 22 2024 at 16:03 UTC