Wasmtime GitHub notifications bot (Sep 27 2023 at 21:48): Wasmtime GitHub notifications bot (Sep 27 2023 at 21:48):pchickey commented on issue #7099:
Can you take a look at #7029 and see what sort of conflicts this might produce? I would like to land that PR first if possible.
I haven't looked at the clock math but if there are issues there which you wrote a fix for here, please submit that as a separate PR and we can look at that specific issue first.
Wasmtime GitHub notifications bot (Sep 27 2023 at 21:55):rvolosatovs commented on issue #7099:
Can you take a look at #7029 and see what sort of conflicts this might produce? I would like to land that PR first if possible.
I don't there are many, if any. If #7029 was merged first, we'd need to add the wrappers in file FD checks, but it seems that it would be the only thing.
Wasmtime GitHub notifications bot (Sep 27 2023 at 21:56):rvolosatovs edited a comment on issue #7099:
Can you take a look at #7029 and see what sort of conflicts this might produce? I would like to land that PR first if possible.
I don't think there are many. If #7029 was merged first, we'd need to add the wrappers in file FD checks, but it seems that it would be the only thing.
Wasmtime GitHub notifications bot (Oct 03 2023 at 10:27):rvolosatovs commented on issue #7099:
I've rebased on top of #7029, the diff is now a bit bigger, since it contains a few minor fixups for that PR focused on simplifying implementation of this feature and consistency
Last updated: Dec 23 2024 at 13:07 UTC