wasmtime / issue #7029 Start to port Wasmtime to the new ... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / issue #7029 Start to port Wasmtime to the new ...

Wasmtime GitHub notifications bot (Sep 27 2023 at 18:55):

Ok, I've now fixed all the get_mut/with_mut issues, with a solution that I think works fairly well, which ends up implementing some amount of RefCell because RefCell itself pulls in static initializers.

And I've now updated the HTTP code to use handles for polling and streams.

Things that still need to be done:

Make stdio functions callable multiple times somehow, or add some kind of debug output API.

Figure out why cargo-vet doesn't like wit-bindgen 0.12

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:02):

alexcrichton commented on issue #7029:

If you run cargo vet locally does it fix the vet issues? (I think I'm listed there as "trust anything published by alex")

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:04):

sunfishcode commented on issue #7029:

I get the same error locally:

$ cargo vet --locked
Vetting Failed!

5 unvetted dependencies:
  wit-bindgen:0.12.0 missing ["safe-to-deploy"]
  wit-bindgen-core:0.12.0 missing ["safe-to-deploy"]
  wit-bindgen-rust:0.12.0 missing ["safe-to-deploy"]
  wit-bindgen-rust-lib:0.12.0 missing ["safe-to-deploy"]
  wit-bindgen-rust-macro:0.12.0 missing ["safe-to-deploy"]
````
~~~

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:05):

alexcrichton commented on issue #7029:

Ah if you remove --locked it should fill in the relevant bits to commit here

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:06):

sunfishcode commented on issue #7029:

If I remove --locked, it fails in a different way.

$ cargo vet
ERROR   × There are some issues with your policy.audit-as-crates-io entries

Error:   × Some non-crates.io-fetched packages match published crates.io versions
  │   wasmtime-wmemcheck:14.0.0
  help: Add a `policy.*.audit-as-crates-io` entry for them

I get this on the main branch too.

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:09):

alexcrichton commented on issue #7029:

Hm are you using 0.8.0 of cargo vet? I updated the wit-bindgen dep to 0.12.0 locally, ran cargo vet, and it succeeded, but I don't know what that specific error is

Wasmtime GitHub notifications bot (Sep 27 2023 at 19:18):

sunfishcode commented on issue #7029:

Yes, this is cargo-vet 0.8.0. I've now added what appear to be the needed lines for cargo-vet to be happy with wasmtime-wmemcheck, so I've now updated it for wit-bindgen too, and it seems ok now.

Last updated: Oct 23 2024 at 20:03 UTC