Stream: git-wasmtime

Topic: wasmtime / issue #7023 Component model: planned changes t...

Wasmtime GitHub notifications bot (Sep 12 2023 at 22:00):

pchickey opened issue #7023.

Wasmtime GitHub notifications bot (Sep 12 2023 at 22:00):

pchickey assigned issue #7023 to alexcrichton.

Wasmtime GitHub notifications bot (Sep 12 2023 at 22:12):

pchickey assigned issue #7023 to lukewagner.

Wasmtime GitHub notifications bot (Sep 13 2023 at 02:54):

pchickey added the wasm-proposal:component-model label to Issue #7023.

Wasmtime GitHub notifications bot (Sep 13 2023 at 16:41):

lann commented on issue #7023:

@alexcrichton re: https://github.com/WebAssembly/component-model/issues/213#issuecomment-1684072335

Were you hoping for a different encoding of doc comments for preview2 or is that more of a "before 1.0" thing?

Wasmtime GitHub notifications bot (Sep 13 2023 at 22:08):

alexcrichton commented on issue #7023:

Personally I like the idea of sticking to a custom section for the near-term since it works well enough.

Designing a format "for real" will take a nontrivial amount of energy and time. If possible I'd prefer to defer said energy and time into the future. If we one day stop reading the custom section that aligns well with, in my opinion, the intention of custom sections.

So in that sense I feel we've got all the benefit today of using a custom section minus it being "for real", and using a more official solution is hopefully postpon-able into the future.

Wasmtime GitHub notifications bot (Sep 20 2023 at 22:11):

pchickey commented on issue #7023:

https://github.com/WebAssembly/component-model/pull/248

Wasmtime GitHub notifications bot (Oct 05 2023 at 21:38):

alexcrichton assigned issue #7023 to elliottt.

Wasmtime GitHub notifications bot (Oct 17 2023 at 18:23):

pchickey commented on issue #7023:

@alexcrichton is going to get this complete this week, and backported into wasmtime 14 (either pre-release or as a patch)

Wasmtime GitHub notifications bot (Oct 19 2023 at 16:24):

alexcrichton commented on issue #7023:

This landed in https://github.com/bytecodealliance/wasm-tools/pull/1252 and is present in wit-component 0.16.0. Wasmtime 14 is being updated in https://github.com/bytecodealliance/wasmtime/pull/7294 and Wasmtime 15+ is updated in https://github.com/bytecodealliance/wasmtime/pull/7286

Wasmtime GitHub notifications bot (Oct 20 2023 at 15:51):

alexcrichton commented on issue #7023:

Wasmtime's test suite passes with WIT_COMPONENT_ENCODING_V2=1 as an environment variable and I've confirmed it produces artifacts not readable with wasm-tools-1.0.47 (as expected).

I think this means everything is going smoothly, so this'll ride the same train as https://github.com/bytecodealliance/wasm-tools/issues/1205 in terms of eventually we'll switch to emitting the new syntax by default, wait another release, then purge support for the old syntax.

Wasmtime GitHub notifications bot (Nov 15 2023 at 17:39):

pchickey closed issue #7023.

Last updated: Oct 23 2024 at 20:03 UTC