pchickey opened issue #7023.
pchickey assigned issue #7023 to alexcrichton.
pchickey assigned issue #7023 to lukewagner.
pchickey added the wasm-proposal:component-model label to Issue #7023.
lann commented on issue #7023:
@alexcrichton re: https://github.com/WebAssembly/component-model/issues/213#issuecomment-1684072335
Were you hoping for a different encoding of doc comments for preview2 or is that more of a "before 1.0" thing?
alexcrichton commented on issue #7023:
Personally I like the idea of sticking to a custom section for the near-term since it works well enough.
Designing a format "for real" will take a nontrivial amount of energy and time. If possible I'd prefer to defer said energy and time into the future. If we one day stop reading the custom section that aligns well with, in my opinion, the intention of custom sections.
So in that sense I feel we've got all the benefit today of using a custom section minus it being "for real", and using a more official solution is hopefully postpon-able into the future.
pchickey commented on issue #7023:
alexcrichton assigned issue #7023 to elliottt.
pchickey commented on issue #7023:
@alexcrichton is going to get this complete this week, and backported into wasmtime 14 (either pre-release or as a patch)
alexcrichton commented on issue #7023:
This landed in https://github.com/bytecodealliance/wasm-tools/pull/1252 and is present in wit-component 0.16.0. Wasmtime 14 is being updated in https://github.com/bytecodealliance/wasmtime/pull/7294 and Wasmtime 15+ is updated in https://github.com/bytecodealliance/wasmtime/pull/7286
alexcrichton commented on issue #7023:
Wasmtime's test suite passes with
WIT_COMPONENT_ENCODING_V2=1
as an environment variable and I've confirmed it produces artifacts not readable with wasm-tools-1.0.47 (as expected).I think this means everything is going smoothly, so this'll ride the same train as https://github.com/bytecodealliance/wasm-tools/issues/1205 in terms of eventually we'll switch to emitting the new syntax by default, wait another release, then purge support for the old syntax.
pchickey closed issue #7023.
Last updated: Dec 23 2024 at 12:05 UTC