Stream: git-wasmtime

Topic: wasmtime / issue #6979 Cranelift: Improve codegen of stor...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 10 2023 at 04:00):

mchesser commented on issue #6979:

Thanks for the review.

I've updated the MovImmM variant to only allow i32s. Based on my understanding, I believe using the simm32 helper for converting the imm is sufficient (since it returns None when the value doesn't fit), and it looks like the fallback case is hit when the value doesn't fit in the updated tests -- but let me know if this isn't the right way to do things.

Changing MovImmM also affected winch, however it looks like winch already panics for large values in this case so I just tried to keep the behavior the same.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 10 2023 at 05:44):

github-actions[bot] commented on issue #6979:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Oct 23 2024 at 20:03 UTC