Wasmtime GitHub notifications bot (Sep 06 2023 at 17:58): Wasmtime GitHub notifications bot (Sep 06 2023 at 17:58):uweigand commented on issue #6970:
FYI @cfallin @fitzgen
Wasmtime GitHub notifications bot (Sep 06 2023 at 20:44):github-actions[bot] commented on issue #6970:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 12 2023 at 17:56):cfallin commented on issue #6970:
@uweigand it looks like this hit some exhaustiveness-check compile errors in CI under some configuration...
Wasmtime GitHub notifications bot (Sep 12 2023 at 18:22):uweigand commented on issue #6970:
I was curious initially why we couldn't just have one "pre" hook and one "post" hook -- i.e., why we need to separate the clobber-save/restore step -- but at least for the prologue, I guess the answer is that we insert the stack-check beforehand. For the epilogue the ABI code really does just invoke one hook then the other; but for symmetry it's kind of nice to keep the hooks paired. Does that match your thinking?
Yes, exactly.
@uweigand it looks like this hit some exhaustiveness-check compile errors in CI under some configuration...
Looks like this was an issue with a change to the riscv64 back-end that happened in the meantime. I've rebased this PR now.
Wasmtime GitHub notifications bot (Sep 13 2023 at 17:59):fitzgen commented on issue #6970:
Been at WasmCon and on PTO so I'm just seeing this now, but I wanted to say that this is a great refactoring! Thanks @uweigand!!
Last updated: Dec 23 2024 at 13:07 UTC