Stream: git-wasmtime

Topic: wasmtime / issue #6942 Enhance `async` configuration of `...

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:12):

yowl commented on issue #6942:

"This is done thinking that the majority of functions probably want to be async" in real life this may be true. For tests however, if the target runtime, and I'm concerned with dotnet CoreCLR, requires WASI support then we need to run the wit-bindgen tests with async support and while I'm not sure of the extent of the async requirements yet, it may just be the Instantiate function. Just a comment really, I can add all the test methods to the exclude list.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:14):

yowl edited a comment on issue #6942:

"This is done thinking that the majority of functions probably want to be async" in real life this may be true. For tests however, if the target runtime, and I'm concerned with dotnet CoreCLR, requires WASI support then we need to run the wit-bindgen runtime tests with async support and while I'm not sure of the extent of the async requirements yet, it may just be the Instantiate function. Just a comment really, I can add all the test methods to the exclude list.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:19):

yowl commented on issue #6942:

Actually thinking about this a bit more, as the tests are "round trip" and the import list is the same as the export list, if I have to change all the tests to async (because exports are always async), then I don't think this PR really affects me: I've got to change the test implementation signatures anyway.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:20):

alexcrichton commented on issue #6942:

Good point! I think I'll update to:

bindgen!({
    async: true,
    async: false,
    async: {
        except_imports: ["..."],
        only_imports: ["..."],
    }
});

to handle that case. That also keeps everything in the async key which I like better.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:33):

alexcrichton commented on issue #6942:

Ok I've updated with a new syntax which has either "only these imports" or "except these imports" options which I think should handle your case @yowl

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:34):

alexcrichton commented on issue #6942:

Oh oops I didn't see your latest comment until just now, well in any case I think this is a better syntax regardless!

Wasmtime GitHub notifications bot (Aug 31 2023 at 16:35):

pchickey commented on issue #6942:

Thanks! This will help in many places

Last updated: Dec 23 2024 at 12:05 UTC