Wasmtime GitHub notifications bot (Aug 30 2023 at 20:04): Wasmtime GitHub notifications bot (Aug 30 2023 at 20:04):jameysharp commented on issue #6937:
I'm handing review of this off to Alex as the author of the API you're extending.
I had hoped that the
from_trusted_fileentry-point or similar would suffice to avoid embedders needing to detect for themselves whether they were holding on to a precompiled module. However, it sounds like both of you have reasons why that wasn't enough. I don't want to think about it that hard so I'll leave you to it.
Wasmtime GitHub notifications bot (Aug 30 2023 at 21:44):github-actions[bot] commented on issue #6937:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Aug 30 2023 at 22:53):acfoltzer commented on issue #6937:
I'm still getting acquainted with the component side of the crate API, but it seems like a
ModuleOrComponenttype is going to be necessary on the client side for pretty much any transitional project. If the expectation is that most applications will eventually move to the component model, I don't think it's worth codifying that sort of type in the crate API. But if you're feeling the pain while maintaining the CLI as well, it might be worth thinking more about some shared interfaces.
Last updated: Nov 22 2024 at 16:03 UTC